Investigate flaky test-net-socket-timeout #9678

Activity

1. Trott

   added

   testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.

   on Nov 18, 2016
2. Trott commented on Nov 18, 2016

   

   Trott

   on Nov 18, 2016

   MemberAuthor

   More actions

   @nodejs/testing There is a familiar cause for this test failure but there are (at least) two options for fixing. I'm not sure which path is correct. Help?

   So, this looks like another of those "busy under-powered machine fires timeouts unreliably" and the solution is to just remove the 200ms timeout that fails the test.

   But that timeout is firing reliably-ish. It's the socket timeout that seems to be delayed. Because there is a socket timeout of 100ms. So, that socket timeout should be firing before the timer timeout. (Although maybe part of the issue is that the execution duration after the timer timeout is set is not just 100ms for socket but 100ms for socket timeout + other stuff like maybe connecting or whatever?)

   SO....two options:

   • Remove the timer timeout. Upside is it should make the test reliable. Downside is that we are no longer testing that a 100ms socket timeout occurs in less than 200ms, which seems like a valid-ish test, no?
   • Move the test from parallel to sequential so that other tests consuming resources won't affect it and cause a failure. I'm leaning towards that if a stress test shows no failures.

   Thoughts?
3. Trott commented on Nov 18, 2016

   

   Trott

   on Nov 18, 2016

   MemberAuthor

   More actions

   Stress test: https://ci.nodejs.org/job/node-stress-single-test/1061/nodes=freebsd10-64/console
4. mscdex

   added

   netIssues and PRs related to the net subsystem.Issues and PRs related to the net subsystem.

   on Nov 18, 2016
5. cjihrig commented on Jan 5, 2017

   

   cjihrig

   on Jan 5, 2017

   Contributor

   More actions

   Closing per #10172. Let me know if that is not correct.
6. cjihrig

   closed this as completedon Jan 5, 2017