Repository navigation
inheritance of C/C++ Addons doesn't work #9288
Description
- Version: v6.9.1
- Platform: Win7 SP1, 64-Bit
- Subsystem:
There is an issue with the inheritance of native node addons in Node v6.9.1.
The problem doesn't exist with Node v4.6.1 or Node v7.0.0.
To reconstruct, i used the example code of Node docs (https://nodejs.org/dist/latest-v6.x/docs/api/addons.html#addons_wrapping_c_objects) and ran the code with this example:
"use strict";
const addon = require('./build/Release/addon');
class Test extends addon.MyObject {
constructor() {
super();
this.doOutput();
}
doOutput() {
console.log("hello world");
}
}
var obj = new Test();Result is:
TypeError: this.doOutput is not a function
The problem is, that the this is empty after super() call.
Activity
bnoordhuis commentedon Oct 26, 2016
This was fixed in V8 5.2 in commit v8/v8@73ee7943 but it also depends on commit v8/v8@306c412c which is arguably an ABI change and therefore not eligible for back-porting. I'll open a pull request for further discussion.
bnoordhuis commentedon Oct 26, 2016
#9293
test: add new.target add-on regression test
test: add new.target add-on regression test
test: add new.target add-on regression test
stixx200 commentedon Jan 10, 2017
@bnoordhuis Do you know, which node v6 version will fix this issue?
addaleax commentedon Jan 12, 2017
@stixx200 Whatever version the changes in #9293 land in (if they do at all).
deps: back-port 306c412c from v8 upstream
deps: back-port 73ee7943 from v8 upstream
v8: drop v8::FunctionCallbackInfo<T>::NewTarget()
test: add new.target add-on regression test
bnoordhuis commentedon Mar 2, 2017
Fixed in 1d631ce...2ebceed, will be in the next v6.x release.
deps: back-port 306c412c from v8 upstream
deps: back-port 73ee7943 from v8 upstream
v8: drop v8::FunctionCallbackInfo<T>::NewTarget()
test: add new.target add-on regression test