Repository navigation
AIX: pseudo-tty/no_dropped_stdio failures on new machine #7973
Description
Activity
@mhdawson Anything different about this new machine? Didn't it pass on the old ones?
Related to JOBS= ?
It did pass on the old one. The previous machine was a vm from siteox with different levels of the OS as opposed to the new ones that are from osusol. I have asked @gireeshpunathil to investigate.
The test case want to make sure every byte that is written to the standard stream is drained before the process exits, basically 1025 characters with 21 new lines.
The test case seem to have devised to validate an OS X behavior on the 1025th character. However in AIX case, at times it receives none while the python parent expects 21 lines.
The stdout of the child is piped into a tempfile, which is later read by the python parent.
I tried to isolate the issue in a number of manners without success: (though many of these different variant of one or two discrete scenarios)
- node no_dropped_stdio.js | xargs echo
- node no_dropped_stdio.js | wc -c
- node no_dropped_stdio.js > out.txt 2>&1
- A ndoe parent with piped streams for the child
- A node parent with inherited streams for the child
- A node parent with file fd passed for child streams and later read from the file
So it looks like the python parent in the test framework has something peculiar or the machine I am running is different from the new CI one.
@mhdawson how easy it is to get hold of the failing CI system for debugging?
Created this request to get Gireesh access nodejs/build#463
@gireeshpunathil None of those will work correctly. Your examples are all pipes.
You need to use a faked TTY. Either via pty.js or via the python test runner in
pseudo-tty, which uses a faked TTY. (Code mostly intools/test.py.)To be clear: if AIX actually fails this then there is a big problem on AIX even if the test was designed for OS X.
Thanks @Fishrock123 - yes, I agree that all the above cases are variants of pipes.
I actually debugged the python code, and validated that the spawing code does not use faketty in this specific scenario, rather creates a temp file, its fd piped into the child node's streams, and then upon child termination, close the fd and read from the file - hence my attempt to mimic the behavior through case 6 above.
However, this is really useful information, I will study the faketty and debug further by taking lead from that. Thanks for the suggestion.
25 remaining items
- added 2 commits that reference this issue
on Nov 23, 2016 - added 2 commits that reference this issue
on Dec 5, 2016 - added a commit that references this issue
on Mar 20, 2017 - added a commit that references this issue
on Mar 21, 2017 - added a commit that references this issue
on Jul 27, 2026
Failures on new AIX machine: https://ci.nodejs.org/job/node-test-commit-aix/nodes=aix61-ppc64/283/console
# # assert.js:89 # throw new assert.AssertionError({ # ^ # AssertionError: 1 == 42 # at ChildProcess. (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-stdio-closed.js:25:10) # at ChildProcess. (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/common.js:411:15) # at emitTwo (events.js:106:13) # at ChildProcess.emit (events.js:191:7) # at Process.ChildProcess._handle.onexit (internal/child_process.js:204:12) --- ... length differs. expect=21 actual=0 patterns: pattern = ^oooooooooooooooooooooooooooooooooooooooooooooooo$ pattern = ^oooooooooooooooooooooooooooooooooooooooooooooooo$ pattern = ^oooooooooooooooooooooooooooooooooooooooooooooooo$ pattern = ^oooooooooooooooooooooooooooooooooooooooooooooooo$ pattern = ^oooooooooooooooooooooooooooooooooooooooooooooooo$ pattern = ^oooooooooooooooooooooooooooooooooooooooooooooooo$ pattern = ^oooooooooooooooooooooooooooooooooooooooooooooooo$ pattern = ^oooooooooooooooooooooooooooooooooooooooooooooooo$ pattern = ^oooooooooooooooooooooooooooooooooooooooooooooooo$ pattern = ^oooooooooooooooooooooooooooooooooooooooooooooooo$ pattern = ^oooooooooooooooooooooooooooooooooooooooooooooooo$ pattern = ^oooooooooooooooooooooooooooooooooooooooooooooooo$ pattern = ^oooooooooooooooooooooooooooooooooooooooooooooooo$ pattern = ^oooooooooooooooooooooooooooooooooooooooooooooooo$ pattern = ^oooooooooooooooooooooooooooooooooooooooooooooooo$ pattern = ^oooooooooooooooooooooooooooooooooooooooooooooooo$ pattern = ^oooooooooooooooooooooooooooooooooooooooooooooooo$ pattern = ^oooooooooooooooooooooooooooooooooooooooooooooooo$ pattern = ^oooooooooooooooooooooooooooooooooooooooooooooooo$ pattern = ^oooooooooooooooooooooooooooooooooooooooooooooooo$ pattern = ^ooooooooooooooooooooooooO$ outlines: not ok 1170 pseudo-tty/no_dropped_stdio --- duration_ms: 0.186