Repository navigation
openSync/writeSync/closeSync produces empty file #7879
Description
Code:
var fd = fs.openSync("abc.txt", "w");
var buf = Buffer.from("Was here.\n");
fs.writeSync(fd, buf);
fs.closeSync(fd);
produces empty file. Expected is that it writes whole buffer. Note that fs.writeSync(fd, "Was here.\n"); writes whole string.
- Version:
v6.2.2 - Platform:
Darwin MacBook-Pro-3.local 14.5.0 Darwin Kernel Version 14.5.0: Thu Apr 21 20:40:54 PDT 2016; root:xnu-2782.50.3~1/RELEASE_X86_64 x86_64 - Subsystem:
fs(?)
Activity
saghul commentedon Jul 26, 2016
The
writeSynccall returns 0, which means no data was written. Didn't have time to investigate further.addaleax commentedon Jul 26, 2016
fs.writeSync(fd, buf, 0, buf.length);should work; right now,fs.writeSyncalways uses thelengthargument, even when it’sundefined. I doubt that’s intentional, though.papandreou commentedon Jul 26, 2016
Sounds like you've run into the same problem for
writeSyncas I did withwritea few days ago: #7856gracjan commentedon Jul 26, 2016
@papandreou: looks alike. Will the fix there also fix my issue?
papandreou commentedon Jul 26, 2016
I don't think it will in its current state, no. I'm on holiday for the next week, but will make sure to pick it up if noone else has landed a fix in the mean time. It's weird, seems like this bug has been there since at least 0.6. It really is the most basic form of
fs.write(Sync)-- and now the two of us both discover it within half a week :)gracjan commentedon Jul 26, 2016
@papandreou, alternatevly you could change this here
node/src/node_file.cc
Line 1001 in c86c1ee
WriteBufferaccepts the following spec:As I understand
WriteBufferis common meeting point for allwriteandwriteSyncfunctions. Thos functions could be simplified afterWriteBuffergets new functionality.papandreou commentedon Dec 27, 2016
Fixed by #7856 (released in 7.2.0). This issue can be closed now.