deps: fix TODO in tools/icu/README.md

Subsystem: deps

Fix TODO in https://github.com/nodejs/node/blob/master/tools/icu/README.md

small-icu is the default now.

watch out for deps/icu-small/source/data/in/icudt*.dat :

that's where a 2MB binary file will be - make sure to git add it
don't forget to delete the old ICU's file

@srl295

/ping @srl295 There are two TODOs in the icu README. Are either of them addressable at this time?

also:

it should mention pre-landing to simplify the diffs (with fix-whitespace - what I do is actually "pre-land" the patch using the Collaborator's guide onto a fresh master, then push that again otherwise the PR diff shows gratuitous whitespace diffs that aren't really part of the final land)
it should also cleanup the order of operations and mention running the license generator after 'make distclean ; configure ' so that the path to ICU is consistent

doc: Update tools/icu/README.md

Navigation Menu

Repository navigation

deps: fix TODO in tools/icu/README.md #7843

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

deps: fix TODO in tools/icu/README.md #7843

Description

Activity

srl295 commented on Jul 22, 2016

Trott commented on Jul 9, 2017

srl295 commented on Nov 10, 2017

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions