Compilation issues on i586

[AdamMajer]

Looks like there's a build failure on linux 32-bit x86 only. (openSUSE Tumbleweed i586 arch)

[  845s] In file included from ../src/util.h:29,
[  845s]                  from ../src/crypto/crypto_clienthello-inl.h:28,
--
[ 2893s] ../deps/v8/src/strings/string-hasher.cc:29:12: error: ‘_mm_cvtsi128_si64’ was not declared in this scope; did you mean ‘_mm_cvtsi32_si64’?
[ 2893s]    29 |     return _mm_cvtsi128_si64(_mm_packus_epi16(x, x));
[ 2893s]       |            ^~~~~~~~~~~~~~~~~
[ 2893s]       |            _mm_cvtsi32_si64
[ 2893s] ../deps/v8/src/strings/string-hasher.cc: In static member function ‘static uint64_t v8::internal::ConvertTo8BitHashReader::Read32(const uint8_t*)’:
[ 2893s] ../deps/v8/src/strings/string-hasher.cc:50:12: error: ‘_mm_cvtsi128_si64’ was not declared in this scope; did you mean ‘_mm_cvtsi32_si64’?
[ 2893s]    50 |     return _mm_cvtsi128_si64(_mm_packus_epi16(x, x));
[ 2893s]       |            ^~~~~~~~~~~~~~~~~
[ 2893s]       |            _mm_cvtsi32_si64

[Renegade334]

Should just be a case of correctly gating the x64 SSE instructions.

Can you test the following patch, if AOK then we can look to upstream it.

diff --git a/deps/v8/src/strings/string-hasher.cc b/deps/v8/src/strings/string-hasher.cc
index bea067c6f0..42dc676228 100644
--- a/deps/v8/src/strings/string-hasher.cc
+++ b/deps/v8/src/strings/string-hasher.cc
@@ -24,7 +24,7 @@ struct ConvertTo8BitHashReader {
     DCHECK_LE(p[5], 0xff);
     DCHECK_LE(p[6], 0xff);
     DCHECK_LE(p[7], 0xff);
-#ifdef __SSE2__
+#if defined(__SSE2__) && defined(V8_TARGET_ARCH_64_BIT)
     __m128i x = _mm_loadu_si128(reinterpret_cast<const __m128i*>(p));
     return _mm_cvtsi128_si64(_mm_packus_epi16(x, x));
 #elif defined(__ARM_NEON__)
@@ -45,7 +45,7 @@ struct ConvertTo8BitHashReader {
     DCHECK_LE(p[1], 0xff);
     DCHECK_LE(p[2], 0xff);
     DCHECK_LE(p[3], 0xff);
-#ifdef __SSE2__
+#if defined(__SSE2__) && defined(V8_TARGET_ARCH_64_BIT)
     __m128i x = _mm_loadu_si64(reinterpret_cast<const __m128i*>(p));
     return _mm_cvtsi128_si64(_mm_packus_epi16(x, x));
 #elif defined(__ARM_NEON__)

[AdamMajer]

Thanks! I can confirm the compilation issue is fixed with this changes.

[clinew]

Confirming the patch worked for me and at least two other Gentoo users in https://bugs.gentoo.org/show_bug.cgi?id=979799

[apteryks]

@Renegade334 is there a PR opened for this change? I just tested it and it works to build node 26.10.0 on i686-linux with Guix.