Repository navigation
Calls to v8::Template::Set must not pass in non-primitive values #6216
Description
Activity
I can investigate this next week. If anyone else is interested in investigating, feel free (but let me know).
I checked earlier today. It looks like it's fairly straightforward to fix in core (don't know yet how or if it affects performance) but it's going to create a lot of fallout in the module ecosystem. Again. Le sigh.
Yeah, if only node had a proper API ...
When is the patch that causes this landing? Not in v6 right?
It's part of v8 5.2 which @bnoordhuis tells me is v7 timeframe
22 remaining items
- added a commit that references this issue
on Oct 5, 2016 - added a commit that references this issue
on Oct 3, 2024
Steps to repro: apply https://codereview.chromium.org/1839983002/ to v8, attempt to run node.js
Templates are globally shared objects, if a template references a non-primitive value (i.e. anything but numbers, strings, or other templates), two things happen
To fix this, you can either introduce an accessor with the same name, and have the getter return the value (Template::SetAccessorProperty), or you can install a native data property. That will look like a regular value to JS, but under the hood, a getter is invoked (Template::SetNativeDataProperty)
/cc @ofrobots @nodejs/v8