You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looks like cstr.cpp breaks under MSVC because of IcuBug:12451.
The good part is, the fix would essentially #ifdef out this file for node's use, so I can probably just add it to the exclusion list for essentially the same behavior.
@srl295 is this required for #3476? I went through upstream changes and the known issues (esp the one you brought up, but also performance) seems a bit concerning.
@jbergstroem not "required for" but "ideally lands before" to avoid having to bump #3476 itself also.
Re the known issues:
node/v8 does not use Transliteration, so is unaffected. The data and code is not included in node.
the Visual Studio issues are for building ICU from ICU's project files, which node doesn't use (hi gyp). I have updated the known issues to be more clear.
Activity
MylesBorins commentedon Apr 5, 2016
@srl295 cc me when you have a PR in and I'll test it out
srl295 commentedon Apr 5, 2016
@thealphanerd thx, let me verify windows first. Passes all tests except
test-tick-processorwhich I doubt I broke (famous last words?)ghaiklor commentedon Apr 5, 2016
@srl295 no, you didn't 😺
See #5903 (comment)
srl295 commentedon Apr 5, 2016
Looks like
cstr.cppbreaks under MSVC because of IcuBug:12451.The good part is, the fix would essentially
#ifdefout this file for node's use, so I can probably just add it to the exclusion list for essentially the same behavior.jbergstroem commentedon Apr 5, 2016
@srl295 is this required for #3476? I went through upstream changes and the known issues (esp the one you brought up, but also performance) seems a bit concerning.
srl295 commentedon Apr 5, 2016
@jbergstroem not "required for" but "ideally lands before" to avoid having to bump #3476 itself also.
Re the known issues:
gyp). I have updated the known issues to be more clear.srl295 commentedon Apr 5, 2016
works on windows… PR incoming
tools: fix license-builder.sh again for ICU
deps: Intl: ICU 57 bump
12 remaining items
tools: fix license-builder.sh again for ICU
tools: fix license-builder.sh again for ICU
deps: Intl: ICU 57 bump
deps: Intl: ICU 57 bump
tools: fix license-builder.sh again for ICU
srl295 commentedon Sep 20, 2016
fyi @jasnell
deps: Intl: ICU 57 bump