Fix rejectUnauthorized: undefined in tls.connect, requestCert in tls.createServer

There are two usability issues in tls module:

tls.connect treats rejectUnauthorized !== true as a false value, even more rejectUnauthorized: undefined is treated as a false. Clearly it should be completely reversed, only when rejectUnauthorized is false - it should be disabled. (This is semver-major)
tls.createServer should change default value of requestCert to true. (Note: we should verify that it still works 😉 ) (semver-major as well)

tls.createServer should change default value of requestCert to true.

Did you mean rejectUnauthorized? requestCert is for making the server request client certificates.

@indutny

@indutny can I remove _tls_legacy.js as well? Since is semver-major change.

@ghaiklor

@jhamhader

@jhamhader see #5923 . Your PR has conflicts, better to split removing _tls_legacy and usability fixes to different PR.

UPD: I see, conflicts resolved.

I think this is fixed now that #5923 has landed, feel free to re-open if I’m mistaken.

Navigation Menu