Repository navigation
Port/Duplicate async_hooks tests to use AsyncLocalStore #55712
Description
Activity
- changed the title
[-]Port/Duplicte async_hooks tests to AsyncLocalStore[/-][+]Port/Duplicate async_hooks tests to use AsyncLocalStore[/+]on Nov 6, 2024 It swaps the default for the flag, but all tests with the
test-async-local-storage-prefix are run both with and without he changes, so test coverage should remain the same.Yes, they run with both. I'm talking more about the tests which don't have the
test-async-local-storage-prefix.
e.g.test-crypto-randomBytesverifies init/before/after/destroy for async-hooks and as long as this test works an async hooks based ALS will likely work fine.
ortest-async-exec-resource-http-32060which has also no variant usingtest-async-local-storage-prefix therefore ALS coverage for that case is lost.Ah, well if there's things which are testing ALS-related behaviour that aren't actually marked as such then there should probably be some tests specific to ALS for those scenarios.
- added a commit that references this issue
on Apr 27, 2025 - added 2 commits that reference this issue
on May 1, 2025 - added 2 commits that reference this issue
on May 6, 2025 - added a commit that references this issue
on May 14, 2025 This issue has been marked as stale due to 210 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.This issue has been automatically closed after 30 days of inactivity following its stale status (no activity for a total of 240 days).
If this is still relevant, feel free to reopen it or leave a comment with additional details so we can continue the discussion.
Short after #55552 was merged I notices that this resulted in loosing a lot test for
AsyncLocalStore.Before
AsyncLocalStorewas based on async hooks. There are plenty of tests for async hooks which implict verified thatAsyncLocalStoredoes what it is expected.But since #55552
AsyncLocalStoreand async hooks are independent.I don't think we have to dup them all, but there are some special cases at least in HTTP area (e.g. here) which might require followups.
fyi @nodejs/diagnostics
Edit 21.11.: corrected link to PR