Repository navigation
test_runner: before hook runs even if it's not followed by any test #53202
Description
Activity
I've had the same thought but in reality just because you don't call any assertion it doesn't mean the test is not doing anything.
Example: #51997
The same it applies tot.before, changing it would break many things.- It's not a test, it's a suite. If test and suite are the technically the same thing, then the suite should respect
--test-name-patternand shouldn't run. Atm there is no way to run a single suite as at leastbeforehook of all other suites are always executed. That makes zero sense. The setup logic in our tests takes minutes. So executing a single test in one suite can take hours, just because all these other suites have their own setup logic inbefore. - Doc: This function is used to create a hook running before subtest of the current test.
Firstly: Before subtest is quite different from before any code/assertions/whatever of the current test. If there are no subtests, thenbeforedoesn't run before anything - it just runs.
Secondly: If test has no subtests, thenbeforehook is completely useless, because it won't run before the code inside the test - that code is already running at that point. This is different fromafter, which you can actually register at any point during the execution and be sure it runs after your code.
- It's not a test, it's a suite. If test and suite are the technically the same thing, then the suite should respect
I'm not sure I understand your point. I'll reopen to hear other collaborators opinion
I think the current behavior for subtests is correct -
before()andafter()should always run. For suites, I think we should do whatever other test runners do forbefore()andafter().My main problem is with suits, because unlike tests, they are not subject to
--test-name-patternfiltering.
So there is no way to prevent executing the code inside them, includingbeforehook.I think the current behavior for subtests
What do you mean by subtests? Don't you mean just tests?
beforeshould always run before any subtests, there is no question about that.
The question is whether it should run for test, without any substests.
Imo it should not. If there are no subtests, then you can't even sensibly define before what the hook is supposed to run:test('test without subtests', async () => { before(async () => { // runs after body1 and body2 (not before) }) console.log('body1') before(() => { // runs after body1 (not before) }); console.log('body2'); })
So you're saying it should always run, but I am asking before what it should always run?
Now if a test does contain subtests, but none of them is executed, it's exactly equivalent to a test without subtests.I think it basically boils down to whether
beforemeans before the current test or before subtests in the current test. I am arguing it can't refer to the current test, because current test is already running, so you can no longer schedule any job before it. So ifbeforerefers to subtests, then give me a practical example where you want to runbeforeif none of the subtests are executed.
The problem is asymmetry withafter, which can actually refer to the currently running test. And indeed this is reflected in the documentation:This function is used to create a hook running before subtest of the current test.
This function is used to create a hook that runs after the current test finishes.
Closing per my last comment.
Version
v20.13.1
Platform
Microsoft Windows NT 10.0.19045.0 x64
Subsystem
test_runner
What steps will reproduce the bug?
Execute with:
node --test --test-name-pattern="nonsence"How often does it reproduce? Is there a required condition?
Always. No.
What is the expected behavior? Why is that the expected behavior?
beforehook shouldn't run if it's not followed by any test. There is no practial or logical reason to runbeforehook alone, it wastes time and resources.What do you see instead?
Additional information
No response