Repository navigation
querystring result not consistent with encodeURIComponent #5309
Description
QueryString has a comment that states the following,
// replaces encodeURIComponent
// http://www.ecma-international.org/ecma-262/5.1/#sec-15.1.3.4
However, the spec states that you should use ToString. In the code, you’re using ValueOf. I.e.
const x = { valueOf: function() { return 'other result'; }, toString: function() { return 'spec result'; } }
encodeURIComponent(x) !== require('querystring').escape(x)
Activity
silentroach commentedon Feb 20, 2016
first comment is about
querystring.escapeand it really replacesencodeURIComponentthe way you expect.if you mean
querystring.stringify- it is not a replacement toencodeURIComponent.jacobp100 commentedon Feb 20, 2016
No, I am talking about
querystring.escape. If you take the object I gave you and run it through bothencodeURIComponentandquerystring.escape, you will get different results.silentroach commentedon Feb 20, 2016
got that, sorry. lets try to fix it :)
querystring: using toString for objects on querystring.escape
querystring: using toString for objects on querystring.escape