[22 regression] Infinite recursion when setting stat.atime

@anonrig

Version

v22.0.0

Platform

Linux

Subsystem

fs

What steps will reproduce the bug?

var fs = requre("fs");
var stat = fs.statSync("./package.json")
stat.atime = 2

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior? Why is that the expected behavior?

It should work

What do you see instead?

It throws

Uncaught RangeError: Maximum call stack size exceeded
    at Stats.set [as atime] (node:internal/fs/utils:469:18)
    at Stats.set [as atime] (node:internal/fs/utils:469:18)
    at Stats.set [as atime] (node:internal/fs/utils:469:18)
    at Stats.set [as atime] (node:internal/fs/utils:469:18)
    at Stats.set [as atime] (node:internal/fs/utils:469:18)
    at Stats.set [as atime] (node:internal/fs/utils:469:18)
    at Stats.set [as atime] (node:internal/fs/utils:469:18)
    at Stats.set [as atime] (node:internal/fs/utils:469:18)
    at Stats.set [as atime] (node:internal/fs/utils:469:18)

Additional information

This is probably caused by fs: make stats date fields lazy #50908 (cc @anonrig), since the setters defined in that PR just call themselves recursively
I found this while investigating NodeJS 22 breaks vinyl-js gulpjs/vinyl-fs#350, which is probably another regression

Another potential bug is that the property is now read-only (even after you access it once to trigger the getter).

I'm opening a PR

I'm seeing the same issue with mtime as well.

Yes, the linked PR will fix both

Navigation Menu

Repository navigation

[22 regression] Infinite recursion when setting `stat.atime` #52705

Version

Platform

Subsystem

What steps will reproduce the bug?

How often does it reproduce? Is there a required condition?

What is the expected behavior? Why is that the expected behavior?

What do you see instead?

Additional information

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[22 regression] Infinite recursion when setting stat.atime #52705

Description

Version

Platform

Subsystem

What steps will reproduce the bug?

How often does it reproduce? Is there a required condition?

What is the expected behavior? Why is that the expected behavior?

What do you see instead?

Additional information

Activity

targos commented on Apr 26, 2024

nicolo-ribaudo commented on Apr 26, 2024

mojavelinux commented on Apr 26, 2024

avivkeller commented on Apr 26, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

[22 regression] Infinite recursion when setting `stat.atime` #52705