V8 CI is broken #48728

Activity

1. richardlau commented on Jul 10, 2023

   

   richardlau

   on Jul 10, 2023

   MemberAuthor

   More actions

   Seems to have started failing last Friday
   e.g. https://ci.nodejs.org/job/node-test-commit-v8-linux/5432/
   https://ci.nodejs.org/job/node-test-commit-v8-linux/5432/nodes=rhel8-s390x,v8test=v8test/console

   10:34:50 + ../../tools/v8/fetch_deps.py .
   10:34:50 Cloning into '/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/_depot_tools'...
   10:34:53   File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/_depot_tools/gclient.py", line 3461
   10:34:53     f'160000,{value},{name}'
   10:34:53                            ^
   10:34:53 SyntaxError: invalid syntax
   10:34:53 Checking out depot_tools.
   10:34:53 Traceback (most recent call last):
   10:34:53   File "../../tools/v8/fetch_deps.py", line 100, in <module>
   10:34:53     FetchDeps(sys.argv[1])
   10:34:53   File "../../tools/v8/fetch_deps.py", line 72, in FetchDeps
   10:34:53     depot_tools = node_common.EnsureDepotTools(v8_path, True)
   10:34:53   File "/home/iojs/build/workspace/node-test-commit-v8-linux/tools/v8/node_common.py", line 40, in EnsureDepotTools
   10:34:53     depot_tools = _Get(v8_path)
   10:34:53   File "/home/iojs/build/workspace/node-test-commit-v8-linux/tools/v8/node_common.py", line 37, in _Get
   10:34:53     cwd=depot_tools)
   10:34:53   File "/usr/lib64/python2.7/subprocess.py", line 223, in check_output
   10:34:53     raise CalledProcessError(retcode, cmd, output=output)
   10:34:53 subprocess.CalledProcessError: Command '['/usr/bin/python', '/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/_depot_tools/gclient.py', 'metrics', '--opt-out']' returned non-zero exit status 1
   10:34:53 make: *** [Makefile:303: v8] Error 1

   It's a bit of a surprise that we are still running fetch_deps.py with Python 2. I'll open a PR to update.
2. richardlau commented on Jul 10, 2023

   

   richardlau

   on Jul 10, 2023

   MemberAuthor

   More actions

   Opened #48729.
   Also needs some updates on the build infrastructure (already applied): nodejs/build#3418
3. richardlau

   added

   v16.x

   v18.x

   v20.x

   on Jul 10, 2023
4. nodejs-github-bot

   closed this as completedin #48729on Jul 12, 2023
5. nodejs-github-bot

   added a commit that references this issue on Jul 12, 2023

   tools: run fetch_deps.py with Python 3

   ...

   6a1316d
6. juanarbol

   added a commit that references this issue on Jul 13, 2023

   tools: run fetch_deps.py with Python 3

   ...

   4398ade
7. richardlau

   added a commit that references this issue on Jul 15, 2023

   ansible: install V8 build deps for Python 3 (#3418)

   ...

   e32c159
8. Ceres6

   added 2 commits that reference this issue on Aug 14, 2023

   tools: run fetch_deps.py with Python 3

   ...

   27123de

   tools: run fetch_deps.py with Python 3

   ...

   ae4e31e
9. richardlau

   added a commit that references this issue on Aug 24, 2023

   tools: run fetch_deps.py with Python 3

   ...

   a578e6d
10. ruyadorno

    added 3 commits that reference this issue on Sep 12, 2023

    tools: run fetch_deps.py with Python 3

    ...

    ab2a804

    tools: run fetch_deps.py with Python 3

    ...

    98663a9

    tools: run fetch_deps.py with Python 3

    ...

    4826379