stream: add an option to let stream.pipeline not throw if the source is destroyed

What is the problem this feature will solve?

Reopening it to discuss.

When using standard source.pipe(dest) source will not be destroyed if dest emits close or an error.

stream.pipeline came to solve this problem but if the source is destroyed it throws an error of premature close.

see the example below:

import stream from 'stream'

setTimeout(() => process.stdin.destroy(), 200);

stream.promises.pipeline(
    process.stdin,
    process.stdout,
    { end: false }
)
// Error [ERR_STREAM_PREMATURE_CLOSE]: Premature close

it works If I explicitly convert it to a readable stream and override it as:

import stream from 'stream'

const stdin = stream.Readable.from(process.stdin, { emitClose: false })
setTimeout(() => stdin.destroy(), 200);

stream.promises.pipeline(
    stdin,
    process.stdout,
    { end: false }
)

Still, for DX reasons pipeline IMHO should be able to consume partial streams without relying on its source if users want to.

cc @nodejs/streams WDYT?

What is the feature you are proposing to solve the problem?

The idea is to add an option to let stream.pipeline not throw if the source is destroyed. This is useful when working with files and an user disconnects from the webserver and it's not needed to consume the full stream

@nodejs/streams

What alternatives have you considered?

No response

I updated the description with additional info

There has been no activity on this feature request for 5 months and it is unlikely to be implemented. It will be closed 6 months after the last non-automated comment.

For more information on how the project manages feature requests, please consult the feature request management document.

I'm sorry to have missed this issue.

Generically, I find this annoying in the promise version, as I often have to try/catch it to ignore that specific error.

Would you like to send a PR?

There has been no activity on this feature request for 5 months. To help maintain relevant open issues, please add the never-stale Issues and PRs exempt from automated stale handling. label or close this issue if it should be closed. If not, the issue will be automatically closed 6 months after the last non-automated comment.
For more information on how the project manages feature requests, please consult the feature request management document.

There has been no activity on this feature request and it is being closed. If you feel closing this issue is not the right thing to do, please leave a comment.

For more information on how the project manages feature requests, please consult the feature request management document.

Navigation Menu

Repository navigation

stream: add an option to let stream.pipeline not throw if the source is destroyed #48667

What is the problem this feature will solve?

What is the feature you are proposing to solve the problem?

What alternatives have you considered?

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

stream: add an option to let stream.pipeline not throw if the source is destroyed #48667

Description

What is the problem this feature will solve?

What is the feature you are proposing to solve the problem?

What alternatives have you considered?

Activity

ErickWendel commented on Jul 6, 2023

github-actions commented on Jan 3, 2024

mcollina commented on Jan 3, 2024

mcollina commented on Jan 3, 2024

github-actions commented on Jul 2, 2024

github-actions commented on Aug 1, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions