You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Would you be able to open an issue or PR on https://github.com/nodejs/node to get feedback on how the Windows installers work, and if it would be appropriate for npm to ship these ps1 scripts in our bin/ dir and have them picked up by the installer?
The npm CLI is almost ready to ship PowerShell scripts (ref: npm/cli#6548). When npm ships these, the Node Windows installer should be updated to place those along with the existing *.cmd files.
My question is how can we ensure that the Windows installer works whether or not the *.ps1 files are present? It would be nice if the commits updating npm and making the Windows installer place the PowerShell scripts didn't need to land at the same time.
I'll hold off on my Node PR until the scripts have officially landed in npm and that version of npm has landed in Node.
Once I do make the Node PR, I'll label it appropriately to indicate that it shouldn't be backported to any Node version that doesn't contain the *.ps1 scripts.
There has been no activity on this feature request for 5 months and it is unlikely to be implemented. It will be closed 6 months after the last non-automated comment.
Activity
lukekarrys commentedon Jun 23, 2023
The
npmCLI is almost ready to ship PowerShell scripts (ref: npm/cli#6548). Whennpmships these, the Node Windows installer should be updated to place those along with the existing*.cmdfiles.My question is how can we ensure that the Windows installer works whether or not the
*.ps1files are present? It would be nice if the commits updating npm and making the Windows installer place the PowerShell scripts didn't need to land at the same time.tools: install npm PowerShell scripts on Windows
bnoordhuis commentedon Jun 24, 2023
https://wixtoolset.org/docs/v3/xsd/wix/file/ - I think the answer is "you can't."
lukekarrys commentedon Jun 24, 2023
If that's that case, then here is my plan:
I'll hold off on my Node PR until the scripts have officially landed in npm and that version of npm has landed in Node.
Once I do make the Node PR, I'll label it appropriately to indicate that it shouldn't be backported to any Node version that doesn't contain the *.ps1 scripts.
github-actions commentedon Dec 22, 2023
There has been no activity on this feature request for 5 months and it is unlikely to be implemented. It will be closed 6 months after the last non-automated comment.
For more information on how the project manages feature requests, please consult the feature request management document.
mribbons commentedon Dec 22, 2023
keep-alive
tools: install npm PowerShell scripts on Windows
tools: install npm PowerShell scripts on Windows
tools: install npm PowerShell scripts on Windows