Buffer.copyBytesFrom should accept a DataView as well.

The issue

The Buffer.copyBytesFrom method was added by the issue #43862. What it does is create a Buffer by copying the data to which the view of an ArrayBuffer or SharedArrayBuffer is referring (“viewing”). The current problem is that it only accepts a TypedArray for its view parameter, when DataViews, too, are views.

> Buffer.copyBytesFrom(new DataView(new SharedArrayBuffer(1024)))
Uncaught:
TypeError [ERR_INVALID_ARG_TYPE]: The "view" argument must be an instance of TypedArray. Received an instance of DataView
    at __node_internal_captureLargerStackTrace (node:internal/errors:490:5)
    at new NodeError (node:internal/errors:399:5)
    at Function.copyBytesFrom (node:buffer:347:11) {
  code: 'ERR_INVALID_ARG_TYPE'
}

My suggestion

I suggest:

enabling Buffer.copyBytesFrom to accept a DataView as well for the view parameter.
modifying the documentation accordingly.

I think I can help with this. I can modify the code to accomodate for dataView.

Relevant comments on why DataView was not added earlier.

#46500 (comment)

To be frank at first glance, it looked manageable to me but it seems it's pretty complex.

Comments suggest that a separate method should be created for this. Would need maintainers' advice.

@jasnell

Relevant comments on why DataView was not added earlier.

#46500 (comment)

#46500 (comment)

To be frank at first glance, it looked manageable to me but it seems it's pretty complex.

Comments suggest that a separate method should be created for this. Would need maintainers' advice.

@jasnell what do you think

There has been no activity on this feature request for 5 months and it is unlikely to be implemented. It will be closed 6 months after the last non-automated comment.

For more information on how the project manages feature requests, please consult the feature request management document.

There has been no activity on this feature request and it is being closed. If you feel closing this issue is not the right thing to do, please leave a comment.

For more information on how the project manages feature requests, please consult the feature request management document.

Navigation Menu

Repository navigation

`Buffer.copyBytesFrom` should accept a `DataView` as well. #47924

The issue

My suggestion

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Buffer.copyBytesFrom should accept a DataView as well. #47924

Description

The issue

My suggestion

Activity

sankalp1999 commented on May 10, 2023

sankalp1999 commented on May 10, 2023

sankalp1999 commented on May 12, 2023

github-actions commented on Nov 9, 2023

github-actions commented on Dec 9, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

`Buffer.copyBytesFrom` should accept a `DataView` as well. #47924