镜像站点 · 本页由第三方 GitHub 只读镜像提供，非 GitHub 官方站点，不接受任何登录或凭据输入。前往 github.com
Skip to content

Non-trivial to build with --ninja on yum-based Linux distros #44286

Closed
#44293
Closed
Non-trivial to build with --ninja on yum-based Linux distros#44286
#44293
Labels
buildIssues and PRs related to Node.js builds or CI infrastructure.

Description

@timClicks
timClicks
opened on Aug 19, 2022

On Linux distros that use the yum package manager, it's cumbersome to build with ninja because you need to remember to create a symlink. yum installs ninja as ninja-build, but this is hard-coded in the Makefile as ninja.

node/Makefile

Line 127 in a2dcc08

ninja -C out/Release $(NINJA_ARGS)

Activity

  1. jdx commented on Aug 19, 2022

    @jdx
    jdx
    on Aug 19, 2022
    Contributor

    I'm not sure if there is a convention for this (like CC or CXX env vars), but maybe this could be NINJA? Or NINJA_BIN?

  2. daeyeon
    added
    buildIssues and PRs related to Node.js builds or CI infrastructure.
    on Aug 19, 2022
  3. nodejs-github-bot
    closed this as completedin #44293on Aug 22, 2022
  4. nodejs-github-bot
    added a commit that references this issue on Aug 22, 2022

    build: added NINJA env to customize ninja binary

    fd07bab
  5. RafaelGSS
    added a commit that references this issue on Sep 5, 2022

    build: added NINJA env to customize ninja binary

    30da2b4
  6. targos
    added a commit that references this issue on Sep 16, 2022

    build: added NINJA env to customize ninja binary

    25c90f2
  7. guangwong
    added 2 commits that reference this issue on Jan 3, 2023

    build: added NINJA env to customize ninja binary

    e6c671e

    build: added NINJA env to customize ninja binary

    8e906f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildIssues and PRs related to Node.js builds or CI infrastructure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions