镜像站点 · 本页由第三方 GitHub 只读镜像提供，非 GitHub 官方站点，不接受任何登录或凭据输入。前往 github.com
Skip to content

http.ServerResponse is not an instance of stream.Writable? #44188

Closed
#45642
restatedev/sdk-typescript
#426
Closed
http.ServerResponse is not an instance of stream.Writable?#44188
#45642
restatedev/sdk-typescript
#426
Labels
confirmed-bugIssues and PRs for confirmed bugs.good first issueIssues that are suitable for first-time contributors.httpIssues and PRs related to the http subsystem.streamIssues and PRs related to Node.js streams.web streamsIssues and PRs related to the Web Streams API.

Description

@sosoba
sosoba
opened on Aug 9, 2022

Version

18.7.0

Platform

Microsoft Windows NT 10.0.19044.0 x64

Subsystem

stream

What steps will reproduce the bug?

import { createServer } from 'node:http';
import { Writable } from 'node:stream';
import { once } from 'node:events';

const server = createServer(async (req, nodeStreamResponse) => {
  const webStreamResponse = Writable.toWeb(nodeStreamResponse);
});
server.listen({ port: 8080 });
await once(server, 'listening');
await fetch('http://localhost:8080');

How often does it reproduce? Is there a required condition?

Always.

What is the expected behavior?

According to the documentation:

Class: http.ServerResponse extends http.OutgoingMessage
Class: http.OutgoingMessage extends Stream

This means that ServerResponse fulfilling the contract Writable.toWeb.

What do you see instead?

TypeError [ERR_INVALID_ARG_TYPE]: The "streamWritable" argument must be an stream.Writable. Received an instance of ServerResponse
    at new NodeError (node:internal/errors:387:5)
    at Object.newWritableStreamFromStreamWritable (node:internal/webstreams/adapters:99:11)
    at Writable.toWeb (node:internal/streams/writable:926:27)

Additional information

Maybe this condition:

if (typeof streamWritable?._writableState !== 'object') {

is too heavy?

Activity

  1. MoLow
    added
    httpIssues and PRs related to the http subsystem.
    on Aug 9, 2022

  2. daeyeon commented on Aug 14, 2022

    @daeyeon
    daeyeon
    on Aug 14, 2022
    Member

    http.ServerResponse is not an instance of stream.Writable?

    Throwing an error here seems to be an expected behavior since http.ServerResponse is an instance of Stream, not stream.Writable. Is this issue a feature request for the following?

    stream.Writable.toWeb(stream : <stream.Writable>|<http.OutgoingMessage>)

  3. daeyeon
    added
    streamIssues and PRs related to Node.js streams.
    web streamsIssues and PRs related to the Web Streams API.
    on Aug 14, 2022

  4. sosoba commented on Aug 17, 2022

    @sosoba
    sosoba
    on Aug 17, 2022
    ContributorAuthor

    It seems that the bug is on @types/node

    class OutgoingMessage extends stream.Writable {

    Of course, the @daeyeon proposition is successful.

    stream.Writable.toWeb(stream : <stream.Writable>|<http.OutgoingMessage>)

  5. ronag
    added
    confirmed-bugIssues and PRs for confirmed bugs.
    on Nov 4, 2022

  6. ronag commented on Nov 4, 2022

    @ronag
    ronag
    on Nov 4, 2022
    Member

    toWeb should work on OutgoingMessage.

  7. ronag
    added
    good first issueIssues that are suitable for first-time contributors.
    on Nov 4, 2022

  8. daltonna commented on Nov 9, 2022

    @daltonna
    daltonna
    on Nov 9, 2022

    Has anyone claimed this issue? I haven't contributed before but I think this would be a good first issue for me as I have some ideas on a fix.

  9. AlexKliger commented on Nov 12, 2022

    @AlexKliger
    AlexKliger
    on Nov 12, 2022

    Was this issue already assigned? If not, I'd like to try and solve it. Thanks.

  10. cola119 commented on Nov 20, 2022

    @cola119
    cola119
    on Nov 20, 2022
    Member

    go for it :)

  11. zeazad-hub commented on Nov 29, 2022

    @zeazad-hub
    zeazad-hub
    on Nov 29, 2022

    Hey, is this issue still open, because I would like to work on it as my first issue.

  12. zeazad-hub commented on Dec 6, 2022

    @zeazad-hub
    zeazad-hub
    on Dec 6, 2022

    Hello, I found out what was going wrong. Our outgoing message defined here does not extend stream.writable. The probelm is that stream.writable has a writable attribute that behaves differently from the OutgoingMessage writabel attribute and this causes test/parallel/test-http-writable-true-after-close.js to fail because it is not writable after it is destroyed. I was wondering if OutgoingMessage.writable should be true when OutgoingMessage.destroyed is true (like the test checks for) or should OutgoingMessage.writable be false when it gets destroyed?

  13. zeazad-hub
    added a commit that references this issue on Dec 8, 2022

    http: change OutgoingMessage so that it inherits from stream.Writable…

    7f40107

  14. daeyeon commented on Dec 9, 2022

    @daeyeon
    daeyeon
    on Dec 9, 2022
    Member

    @zeazad-hub FWIW, there seems to be a performance issue when trying OutgoingMessage inheriting stream.Writable.

  15. nodejs-github-bot
    closed this as completedin #45642on Dec 10, 2022
  16. nodejs-github-bot
    added a commit that references this issue on Dec 10, 2022

    lib: allow Writeable.toWeb() to work on http.Outgoing message

    2ec4189
  17. targos
    added a commit that references this issue on Dec 12, 2022

    lib: allow Writeable.toWeb() to work on http.Outgoing message

    3c7ac01
  18. zeazad-hub
    added 2 commits that reference this issue on Dec 12, 2022

    http: change OutgoingMessage so that it inherits from stream.Writable…

    2531694

    node: removed script.sh file that i created previously

    e46d162
  19. targos
    added a commit that references this issue on Dec 13, 2022

    lib: allow Writeable.toWeb() to work on http.Outgoing message

    302c524
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    confirmed-bugIssues and PRs for confirmed bugs.good first issueIssues that are suitable for first-time contributors.httpIssues and PRs related to the http subsystem.streamIssues and PRs related to Node.js streams.web streamsIssues and PRs related to the Web Streams API.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions