AsyncLocalStore looses context in MakeCallback

Version

18.1.0, 14.19.1 (and most likely a lot others)

Platform

Tested on Microsoft Windows NT 10.0.22000.0 x64 but very likely platform independent.

Subsystem

async_hooks

What steps will reproduce the bug?

Use node::MakeCallback() with a receiver different to the AsyncResource.

See e.g. snappy 6.x which uses Nan::AsyncWorker.

In this setup the complete callback is not called with the AsyncResource as target and this results in setting the wrong object as current resource in MakeCallback.

Calling callbacks with undefined/null/global as target is not that uncommon.

The before/after callbacks are called with the correct asyncId but AsyncLocalStore relies on the current resource.

const { executionAsyncId, AsyncLocalStorage } = require("async_hooks")
const snappy = require("snappy")
const als = new AsyncLocalStorage()

als.run(15, () => {
  snappy.compress("Hello World!", () => {
    const cbId = executionAsyncId()
    console.log(`compressed: ${cbId}, als: ${als.getStore()}`)
  })
})

How often does it reproduce? Is there a required condition?

Always if MakeCallback is used with a receiver different then the AsyncResource object.

What is the expected behavior?

no context loss

What do you see instead?

context loss

Additional information

No response

fyi @nodejs/async_hooks

It's happening only in Windows?

I haven't tried any other OS but I assume it's os independent. Just filled the form.

Also node down to at least 14 is effected.

This issue has been marked as stale due to 210 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

This issue has been automatically closed after 30 days of inactivity following its stale status (no activity for a total of 120 days).
If this is still relevant, feel free to reopen it or leave a comment with additional details so we can continue the discussion.

src: keep ALS store in AsyncResource::MakeCallback

Navigation Menu

Repository navigation

AsyncLocalStore looses context in MakeCallback #43038

Version

Platform

Subsystem

What steps will reproduce the bug?

How often does it reproduce? Is there a required condition?

What is the expected behavior?

What do you see instead?

Additional information

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

AsyncLocalStore looses context in MakeCallback #43038

Description

Version

Platform

Subsystem

What steps will reproduce the bug?

How often does it reproduce? Is there a required condition?

What is the expected behavior?

What do you see instead?

Additional information

Activity

Flarna commented on May 10, 2022

RafaelGSS commented on May 10, 2022

Flarna commented on May 10, 2022

github-actions commented on Jun 25, 2026

github-actions commented on Jul 27, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions