Repository navigation
Unify node.gyp code styling #41072
Description
Activity
\ is used in a couple of other places too. You can run git grep --line-number '\\$' "*.gyp*" to get a full list if you would like to fix them all.
added a commit that references this issue on Dec 4, 2021
added a commit that references this issue on Dec 6, 2021
This issue has been marked as stale due to 210 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.
This issue has been automatically closed after 30 days of inactivity following its stale status (no activity for a total of 120 days).
If this is still relevant, feel free to reopen it or leave a comment with additional details so we can continue the discussion.
Version
16.13.1, maybe also 17.2.0 (not tested myself)
Platform
Microsoft Windows NT 10.0.19043.0 x64
Subsystem
node.gyp
What steps will reproduce the bug?
In #40481, it combines multiple lines of strings with
\before a line break.See node/node.gyp at master · nodejs/node
This
\causes an error in gyp-parser addaleax/gyp-parser: GYP file format parser in JS.I looked at the .gyp docs GYP - Input Format Reference, I wasn't sure if it allowed to combine multiple lines of strings with
\.But any way, it doesn't match code styling in the same file.
In other places, multiple lines are combined like
#L79
#L849
I think #L1479 should follow the same code styling.
How often does it reproduce? Is there a required condition?
Always since 16.13.1
What is the expected behavior?
Do not cause errors in other modules.
What do you see instead?
Parse error in gyp-parser.
Additional information
No response