Repository navigation
Add ability to disable break on first line when using the CLI inspector #40857
Description
Activity
@nodejs/diagnostics
I'm generally +1 on this.
I guess the obvious way to implement this would be as a command-line flag:
node inspect --run index.jsornode inspect --no-break-on-first-line index.jsor something like that. Is there a better/preferable way?I'm thinking in disable by default the break on first line and land it as major. What do you think? @Trott
Does that conflict with the behavior most people would want and expect? Do CLI debuggers in general tend to break on or before the first executable statement by default? I'd be interested to know what the standard Python, Perl, and Ruby CLI debuggers do, for example.
python -m pdb script.pyappears to break on the first line by default.I suspect Perl and Ruby and interpreted/scripting languages in general do the same in their CLI debuggers, but correction is welcome.
I personally would find a different behavior (in a CLI debugger) surprising, but I'm certainly open to the idea if it's the right thing to do.
Reacted by Rafael GonzagaI would be -1 on making it the default. I don't think having
debugger;statements in the code is the common use case.Reacted by Rafael GonzagaBtw, I think we should still always break internally on first line, because otherwise there's a risk that the code with the breakpoint runs before we connect the inspector. An option to automatically continue after this initial pause SGTM.
Btw, I think we should still always break internally on first line, because otherwise there's a risk that the code with the breakpoint runs before we connect the inspector. An option to automatically continue after this initial pause SGTM.
Yes, makes sense.
It looks like there is already an undocumented environment variable that does this. Set
NODE_INSPECT_RESUME_ON_START=1and it should not break on the first line.@Spakman Can you test this and confirm that it works as you expect?
If so, perhaps the solution is to document the environment variable.
- linked a pull request that will close this issuedoc: add information on suppressing initial break in debugger #40960
on Nov 25, 2021 - added a commit that references this issue
on Nov 26, 2021 @Spakman Can you test this and confirm that it works as you expect?
Using this seems to get us part way there, but it's still not behaving in the way I'd expect.
Given this
debugger.js:const hello = 123; console.log("Expect this to be displayed directly in STDOUT."); debugger; console.log("About to exit:", hello);Running
NODE_INSPECT_RESUME_ON_START=1 node inspect debugger.jscorrectly skips the first line, instead breaking on thedebugger;statement. I'd expect the firstconsole.logoutput to appear directly in STDOUT rather than after the debug shell's<(since thedebugger;statement hasn't been executed yet). While I would find that behaviour cleaner, this isn't really the end of the world since if I'm wanting to step through code then I'm likely a bit less concerned about output correctness.Here's the output from that command:
< Debugger listening on ws://127.0.0.1:9229/23c5ccc6-0db3-44bb-832d-66f09aa17b83 < For help, see: https://nodejs.org/en/docs/inspector < connecting to 127.0.0.1:9229 ... ok < Debugger attached. < < Expect this to be displayed directly in STDOUT. < break in debugger.js:3 1 const hello = 123; 2 console.log("Expect this to be displayed directly in STDOUT."); > 3 debugger; 4 console.log("About to exit:", hello); 5 debug> cont < About to exit: 123 < < Waiting for the debugger to disconnect... < debug> .exitA bigger issue for me is that the debug shell is both brought up automatically without any
debugger;statements (causing what I'd consider in this case to be malformed output) and doesn't terminate without user input. With thisno_debugger.js, runningNODE_INSPECT_RESUME_ON_START=1 node inspect no_debugger.jsgives this output:const hello = 123; console.log("Expect this to be displayed directly in STDOUT."); console.log("About to exit:", hello);Here's the output:
< Debugger listening on ws://127.0.0.1:9229/bf6c2802-dfe0-422c-a1a5-7676ee21101e < For help, see: https://nodejs.org/en/docs/inspector < connecting to 127.0.0.1:9229 ... ok < Debugger attached. < < Expect this to be displayed directly in STDOUT. < < About to exit: 123 < < Waiting for the debugger to disconnect... < debug> .exitIn an ideal world, I'd expect running this
no_debugger.jsscript to behave exactly as if I hadn't passed theinspectargument.While it wouldn't solve any output issues, is there perhaps another environment variable that I'm missing to disconnect the debugger automatically when the script exits?
- added a commit that references this issue
on Nov 26, 2021 Because the initial question was about "disable break on first line" and now we're talking about exiting the debugger automatically, I've opened a new issue for that in #40982.
My apologies. I was caught up in my own goals and had conflated somewhat unrelated issues. A new conversation makes perfect sense.
Because the initial question was about "disable break on first line" and now we're talking about exiting the debugger automatically, I've opened a new issue for that in #40982.
My apologies. I was caught up in my own goals and had conflated somewhat unrelated issues. A new conversation makes perfect sense.
Oh, no apology necessary. Scope creep in a conversation is pretty natural. Just trying to keep individual issues from having long conversations attached to them if they are not required.
- added 2 commits that reference this issue
on Jan 30, 2022
Is your feature request related to a problem? Please describe.
I use Node.js to run unit tests in a (Linux) shell. The way this is set up to run is to evaluate each test script as a single invocation of Node.js in series. It's working great!
However, while I do have the ability to use a
debugger;statement (when I invoke each test usingnode inspect a_test_file.js) in these scripts to use the built-in CLI inspector, because of the forced breakpoint on the first line, the debug shell is activated for every test script, which quickly becomes tedious. I'm looking to run something likenode inspect a_test_file.jsand only have it bring up the debug shell if/when adebugger;statement is executed.Describe the solution you'd like
While I do understand the need to break on the first line in many other situations, some method to disable it would be very useful in this circumstance. An environment varible or a command line argument to achieve this would both work well for me.
Describe alternatives you've considered
I'm not aware of any way to work around this.