镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

test-cluster-primary-error flaky in test-asan job #39655

Description

@targos

Example: https://github.com/nodejs/node/runs/3238780435?check_suite_focus=true

I think everybody knows about this one but I couldn't find an existing issue

Activity

  1. added
    flaky-testIssues and PRs involving tests that fail intermittently in CI.
    on Aug 4, 2021
  2. targos commented on Aug 4, 2021

    @targos
    MemberAuthor
    === release test-cluster-primary-error ===
    Path: parallel/test-cluster-primary-error
    Error: Command: out/Release/node /home/runner/work/node/node/test/parallel/test-cluster-primary-error.js
    --- TIMEOUT ---
    
    ===
    === 1 tests failed
    ===
    make[1]: *** [Makefile:513: test-ci] Error 1
    
  3. lpinca commented on Aug 4, 2021

    @lpinca
    Member

    Perhaps a longer timeout is sufficient?

  4. lpinca commented on Aug 4, 2021

    @lpinca
    Member

    It's 5 minutes at the moment so I think it is already more than enough.

  5. tniessen commented on Mar 17, 2022

    @tniessen
    Member

    FWIW, this is still one of the main reasons asan regularly fails, often taking hours for a full run (build + tests). Maybe we should temporarily increase the timeout to 10 minutes and see if that helps?

  6. mhdawson commented on Mar 29, 2022

    @mhdawson
    Member

    Another failure - #42459

  7. Trott commented on Mar 30, 2022

    @Trott
    Member

    Another failure - #42459

    A link to the action results would be much more useful than a link to the PR, where the previous failing Action will be kind of hidden away. So here!: https://github.com/nodejs/node/runs/5684048217?check_suite_focus=true

  8. F3n67u commented on Jun 20, 2022

    @F3n67u
    Contributor
  9. mmomtchev commented on Jun 29, 2022

    @mmomtchev
    Contributor

    I have an environment where it fails every time, but only if it is run as part of the full suite, when running the test independently it passes. It fails along several other tests:
    https://github.com/mmomtchev/libnode/runs/7118719199?check_suite_focus=true#step:7:11745
    I will try to investigate, but if you want to give it a try:

    git clone -b failing-unit-test https://github.com/mmomtchev/libnode.git
    docker build -t yourname/libnode-ubuntu-bionic:latest .
    docker run yourname/libnode-ubuntu-bionic:latest
    
  10. gengjiawen commented on Nov 15, 2022

    @gengjiawen
    Member

    @theanarkh landed a fix on #44066.

  11. jasnell commented on Dec 20, 2022

    @jasnell
    Member

    I'm assuming this is fixed now since #44066 landed? Please re-open if appears to still be flaky.

  12. debadree25 commented on Feb 28, 2023

    @debadree25
    Contributor

    This is probably still an issue
    Example https://github.com/nodejs/node/actions/runs/4290895133/jobs/7475416200
    had seen it at a few other places too but can find the links

    Reopening hence

  13. theanarkh commented on Feb 28, 2023

    @theanarkh
    Contributor

    Yes. The PR is closed.

  14. anonrig commented on Apr 5, 2023

    @anonrig
    Member
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    flaky-testIssues and PRs involving tests that fail intermittently in CI.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions