镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

child_process.spawnSync may results an abort #38070

Description

@zyscoder

What steps will reproduce the bug?

Setup a node instance,

» node

and run the following javascript code.

new tty.ReadStream(4);
child_process.spawnSync('str');

Then the node instance occurs an abort.
In my practice, the only value "4" results in the abort.

How often does it reproduce? Is there a required condition?

This abort can always be triggered following the steps above.

What is the expected behavior?

I noticed that nodejs docs say "In normal circumstances process.stdin will be the only tty.ReadStream instance in a Node.js process and there should be no reason to create additional instances.". Maybe some limitation for users to construct a tty.ReadStream is needed. If any error occurs, an exception or other similar error-reporting stuff should be thrown. There is no reason to abort the whole node process.

What do you see instead?

» node
Welcome to Node.js v14.15.1.
Type ".help" for more information.
> new tty.ReadStream(4);
<ref *1> ReadStream {
 ...
}
> child_process.spawnSync('str');
[2]    2461977 abort      node                                                                                                                                                                                      

Additional information

Activity

  1. added
    child_processIssues and PRs related to the child_process subsystem.
    confirmed-bugIssues and PRs for confirmed bugs.
    ttyIssues and PRs related to the tty subsystem.
    on Apr 4, 2021
  2. changed the title [-]"process.spawnSync" may results an abort[/-] [+]`child_process.spawnSync` may results an abort[/+] on Apr 4, 2021
  3. Ayase-252 commented on Apr 4, 2021

    @Ayase-252
    Member

    Refs: #37780 #38021

    Is using these constructors of both tty.ReadStream or tty.createStream illegal in userland?

  4. addaleax commented on Apr 7, 2021

    @addaleax
    Member

    This is basically of the same kind as #37874, you’re interfering with an fd owned by libuv and see a crash as a consequence of that, not really surprising and not really something that you should do in any case.

    Is using these constructors of both tty.ReadStream or tty.createStream illegal in userland?

    No.

  5. yashLadha commented on Jan 21, 2022

    @yashLadha
    Contributor

    @addaleax If there is no AI can we close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    child_processIssues and PRs related to the child_process subsystem.confirmed-bugIssues and PRs for confirmed bugs.ttyIssues and PRs related to the tty subsystem.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions