Repository navigation
Vendor Events on NPM #37435
Description
Activity
I think we should avoid doing this for any more core modules because of potential compatibility and other issues. We've already encountered this in the past with
readable-streamwhen making certain changes in core coupled with the existence of userland modules that have/hadreadable-streampinned to very old versions, causing incompatibilities and/or breakage. I fear the same could happen for other core modules, which could lead to less innovation/improvements in node core.Additionally, as far as I remember
readable-streamwas created so that streams2 could be used by older/existing/deployed node versions and not (initially) for the benefit of bundler-type projects like browserify.Reacted by Benjamin GruenbaumI think what mscdex says makes sense. It might also be a lot of effort for the Node.js project to turn
eventsinto something that can be consumed by the range of browsers/non-browsers thatbrowserify/eventsaims to support for no clear gain. If it was easy, I would've personally loved to see it happen since I don't have enough time to maintain all the shims that browserify uses, but I think the node.js project probably also has limited time that is better spent elsewhere 😅This didn't get a lot of traction and opinions seem negative - so let's close and reopen if people feel strongly about it.
Context: browserify/events#79
It would be useful if
eventswas vendored in a similar way toreadable-stream.I have brought this possibility up in the events repo https://github.com/browserify/events ( https://www.npmjs.com/package/events )
This should be pretty straightforward given
eventsis mostly self contained.cc @goto-bus-stop :)