镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

promisified pipeline missing AbortSignal support #37321

Description

@ronag
No description provided.

Activity

  1. added
    streamIssues and PRs related to Node.js streams.
    on Feb 11, 2021
  2. ronag commented on Feb 11, 2021

    @ronag
    MemberAuthor
  3. benjamingr commented on Feb 11, 2021

    @benjamingr
    Member

    I can fix this in a week or so. @Linkgoron want to take a stab at this?

  4. Linkgoron commented on Feb 11, 2021

    @Linkgoron
    Contributor

    I can fix this in a week or so. @Linkgoron want to take a stab at this?

    I'll give it a shot. It currently essentially receives (...streams, callback) does it make sense to check if the last parameter is an AbortSignal (i.e. after the callback)?

    What about promisified stream.finished? Does it make sense to add AbortSignal support to it? In theory, you'd expect the consumed stream itself to have cancellation support, but I can see how someone might want to abort waiting.

  5. Linkgoron commented on Feb 13, 2021

    @Linkgoron
    Contributor

    created PR #37359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    streamIssues and PRs related to Node.js streams.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions