make check failure for macOS arch64

Commit 0b6d307

macOS 11.1 aarch64

Xcode 12.3

make; make check

=== release test-worker-prof ===                                              
Path: sequential/test-worker-prof
node:assert:119
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: child exited with signal: {
  status: null,
  signal: 'SIGSEGV',
  output: [ null, '', '' ],
  pid: 73280,
  stdout: '',
  stderr: ''
}
    at Object.<anonymous> (/Users/USERNAME/github/node/test/sequential/test-worker-prof.js:58:10)
    at Module._compile (node:internal/modules/cjs/loader:1108:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1137:10)
    at Module.load (node:internal/modules/cjs/loader:973:32)
    at Function.Module._load (node:internal/modules/cjs/loader:813:14)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:76:12)
    at node:internal/main/run_main_module:17:47 {
  generatedMessage: false,
  code: 'ERR_ASSERTION',
  actual: 'SIGSEGV',
  expected: null,
  operator: 'strictEqual'
}
Command: out/Release/node /Users/USERNAME/github/node/test/sequential/test-worker-prof.js
[02:41|% 100|+ 3282|-   1]: Done                                              
make[1]: *** [jstest] Error 1
make: *** [test] Error 2

@chadbrewbaker

@chadbrewbaker - personally I have not used macos but make check works fine for windows10 os

I don't know if we have collaborators with an M1 Mac yet.

I can reproduce on my machine (M1 CPU).

For info, node --prof always segfaults on Apple Silicon, it's probably a V8 bug. If you don't need this feature, node works perfectly fine though.

I'm not able to compile gdb though, so I can't really help debug this, sorry.

I'm not able to compile gdb though, so I can't really help debug this, sorry.

Maybe you can try lldb instead?

lldb gave me the info I needed 👍

I've submitted the fix to https://chromium-review.googlesource.com/c/v8/v8/+/2609413. @nodejs/v8 is there something else I should do to ensure the fix makes it to the next Node.js releases?

@aduh95

@aduh95 If you want someone to review your CL, you need to mark it as ready for review (it's currently WIP) and ideally add some reviewers.

Edit: it's a bit counter-intuitive, but that's what the "Start review" button allows you to do.

@targos

@targos Thanks for the info! I've now submitted the CL for reviews.

@hashseed

@hashseed can you help get a review of the PR in the V8 changed needed before we can enable testing in the Node.js CI?

[aarm64] Fix GetSharedLibraryAddresses

deps: V8: cherry-pick 8957d4677aa7

deps: cherry-pick 8957d4677aa794c230577f234071af0 from V8 upstream

[aarm64] Fix GetSharedLibraryAddresses

deps: cherry-pick 8957d4677aa794c230577f234071af0 from V8 upstream

Navigation Menu

Repository navigation

make check failure for macOS arch64 #36656

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

make check failure for macOS arch64 #36656

Description

Activity

PoojaDurgad commented on Dec 28, 2020

targos commented on Dec 28, 2020

aduh95 commented on Dec 28, 2020

aduh95 commented on Jan 4, 2021

targos commented on Jan 4, 2021

aduh95 commented on Jan 4, 2021

targos commented on Jan 26, 2021

aduh95 commented on Jan 26, 2021

mhdawson commented on Feb 17, 2021

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions