util.inspect fails to log getters which access this #36045

Activity

1. targos commented on Nov 9, 2020

   

   targos

   on Nov 9, 2020

   Member

   More actions

   @nodejs/util
2. targos

   added

   utilIssues and PRs related to the built-in util module.Issues and PRs related to the built-in util module.

   on Nov 9, 2020
3. BridgeAR

   self-assigned this

   on Nov 9, 2020
4. BridgeAR commented on Nov 9, 2020

   

   BridgeAR

   on Nov 9, 2020

   Member

   More actions

   diff --git a/lib/internal/util/inspect.js b/lib/internal/util/inspect.js
   index e6787760fe..9343b0772f 100644
   --- a/lib/internal/util/inspect.js
   +++ b/lib/internal/util/inspect.js
   @@ -628,7 +628,7 @@ function addPrototypeProperties(ctx, main, obj, recurseTimes, output) {
            continue;
          }
          const value = formatProperty(
   -        ctx, obj, recurseTimes, key, kObjectType, desc);
   +        ctx, obj, recurseTimes, key, kObjectType, desc, main);
          if (ctx.colors) {
            // Faint!
            output.push(`\u001b[2m${value}\u001b[22m`);
   @@ -1678,7 +1678,7 @@ function formatPromise(ctx, value, recurseTimes) {
      return output;
    }
    
   -function formatProperty(ctx, value, recurseTimes, key, type, desc) {
   +function formatProperty(ctx, value, recurseTimes, key, type, desc, original = value) {
      let name, str;
      let extra = ' ';
      desc = desc || ObjectGetOwnPropertyDescriptor(value, key) ||
   @@ -1699,7 +1699,7 @@ function formatProperty(ctx, value, recurseTimes, key, type, desc) {
              (ctx.getters === 'get' && desc.set === undefined) ||
              (ctx.getters === 'set' && desc.set !== undefined))) {
          try {
   -        const tmp = value[key];
   +        const tmp = desc.get.call(original);
            ctx.indentationLvl += 2;
            if (tmp === null) {
              str = `${s(`[${label}:`, sp)} ${s('null', 'null')}${s(']', sp)}`;

   This would be a functional fix. I did not yet check if this causes a performance regression due to mismatching the arguments count frequently.
5. Trott

   added a commit that references this issue on Nov 12, 2020

   util: fix to inspect getters that access this

   ...

   929c51f
6. Trott

   closed this as completedin 929c51fon Nov 12, 2020
7. codebytere

   added a commit that references this issue on Nov 22, 2020

   util: fix to inspect getters that access this

   ...

   4140f49
8. BethGriggs

   added 4 commits that reference this issue on Dec 9, 2020

   util: fix to inspect getters that access this

   ...

   aa69d59

   util: fix to inspect getters that access this

   ...

   3517ced

   util: fix to inspect getters that access this

   ...

   dfb353b