镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

we need CMakeLists.txt #35118

Description

@anlexN

node source code why not have CMakeLists.txt like libuv source code? please give me one.

Activity

  1. mmarchini commented on Sep 9, 2020

    @mmarchini
    Contributor

    We have a strategic initiative to move from gyp to something else, possibly CMake: nodejs/TSC#901. It'll take some time to get it right though

  2. bnoordhuis commented on Sep 9, 2020

    @bnoordhuis
    Member

    Closing as duplicate.

  3. added
    buildIssues and PRs related to Node.js builds or CI infrastructure.
    duplicateIssues and PRs that are duplicates of other issues or PRs.
    on Sep 9, 2020
  4. anlexN commented on Sep 10, 2020

    @anlexN
    ContributorAuthor

    @mmarchini i think that give up gyp and anything about python is good idea. so when to migrate? how many days?

  5. mmarchini commented on Sep 10, 2020

    @mmarchini
    Contributor

    how many days?

    We're talking a couple years probably, that's not something that can be done in a single PR or in a single version.

  6. anlexN commented on Sep 12, 2020

    @anlexN
    ContributorAuthor

    @mmarchini you can talk and talk for many days! but can you first give me CMakeLists.txt? i can not open node source code in jetbrains clion! oh my god. please help me. what IDE do you use?

  7. mmarchini commented on Sep 12, 2020

    @mmarchini
    Contributor

    As mentioned before, adding CMake support is not something we can rush, nor is it an easy task that can be accomplished quickly.

    To build Node.js you can follow the instructions on our build guide: https://github.com/nodejs/node/blob/master/BUILDING.md, it contains the appropriate steps and dependencies for each operating system.

  8. anlexN commented on Sep 12, 2020

    @anlexN
    ContributorAuthor

    what IDE do you use? can you teach me how to open node source code in jetbrains clion?

  9. bnoordhuis commented on Sep 12, 2020

    @bnoordhuis
    Member

    FWIW, I attempted a port to cmake a few years ago: https://github.com/bnoordhuis/io.js/tree/cmake

    The size of the diff says something about the amount of work involved, and ^ supports maybe 50% of the features that the gyp build supports.

  10. mmarchini commented on Sep 12, 2020

    @mmarchini
    Contributor

    I use VSCode + terminal. Just "opening the Node.js source code" should be possible regardless of build system, building it might depend on that's available on Jetbrains. I'm not familiar with Jetbrains specifically so if it has some different requirements I won't be able to help. Working on Node.js with Jetbrains seems to be worth a separate issue though, I suggest opening a new one with as much information as you can provide so other folks can help.

  11. anlexN commented on Sep 13, 2020

    @anlexN
    ContributorAuthor

    @bnoordhuis can you support 100% features?
    @mmarchini libuv source repo have CMakeLists.txt, i believe that node should have one too. we should unify build system. no libuv, no node.

  12. bnoordhuis commented on Sep 13, 2020

    @bnoordhuis
    Member

    If I had infinite time and patience, sure, but I have neither.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildIssues and PRs related to Node.js builds or CI infrastructure.duplicateIssues and PRs that are duplicates of other issues or PRs.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions