Repository navigation
Resource is optional in napi_async_init #33153
Description
Activity
- added a commit that references this issue
on Apr 30, 2020 @legendecas, @Flarna this is what I'd suggest we do:
I don't think we should change the implementation as it would be breaking which we can't do for N-API but updating the doc does make sense.
I've left as draft until I get feedback from @legendecas and @Flarna that this makes sense to them as well.
- added a commit that references this issue
on May 7, 2020 - added a commit that references this issue
on Jun 7, 2020 - added a commit that references this issue
on Jul 27, 2026
Maybe we should also think about adapting
napi_async_initas it states that the resource is optional. As Node is meanwhile built to require an async resource it seems to be strange that we create an object on the fly if user doesn't provide one.Removing the null check in
napi_async_initwould be no issue from ABI point of view but breaking from behavior. Not sure if this should be included in this PR.Originally posted by @Flarna in #32930