worker.isOnline() ?

I have a piece of code that needs to handle present and future workers once at any point during the application life time.

Here is a simple test case

var cluster = require('cluster')

var handleWorker = function(worker) {
  console.log(worker.id)
}

if (cluster.isMaster) {
  for (var i = 0; i < 2; i++) {
    cluster.fork()
  }
  for (var k in cluster.workers) {
    var worker = cluster.workers[k]
    if (worker.isConnected()) handleWorker(worker)
  }
  cluster.on('online', handleWorker)
}

This code outputs:

The intent of the piece of code is to execute something once for each present and future online worker. If we had a isOnline method and I could use it instead of isConnected the code would output:

1
2

Or maybe there is already a way around this?

This is definitively a minor issue/use case; I'm working around it by keeping a list of handled workers but it would be nice if I didn't had to.

Would isOnline be a good solution to the problem? If so I'd be happy to send a PR.

BTW there is the worker.state property that is set to 'online' once the worker is online but it's not a documented feature

In the example you posted an .isOnline property or function wouldn't make a difference. Inside the loop it's always going to be false because 'online' is an asynchronous event.

It might make sense if you have something in there that introduces a discontinuity, like setTimeout() or setImmediate(). Maybe try your hand at a pull request and see what the reactions are.

Closing due to inactivity.

Navigation Menu

Repository navigation

worker.isOnline() ? #3294

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

worker.isOnline() ? #3294

Description

Activity

sonnyp commented on Oct 9, 2015

bnoordhuis commented on Oct 10, 2015

bnoordhuis commented on May 2, 2016

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions