Repository navigation
vm.compileFunction is missing importModuleDynamically #31860
Description
Activity
@devsnek hey 👋 Starting to land ESM support in Jest now, and was looking into supporting
import()in CJS, and hit this again (forgot I filed it 😅). I would offer to help, but I've never done any C++ except for simplistic school assignments some years ago. Looking at #22381 it seems like it's almost entirely C++, but if I can do anything else to help I'd love to!(As an aside, Jest 25.4 includes primitive support for ESM - I'm really digging the APIs! Thanks for all your hard work on this.)
Ah thank you!
- added a commit that references this issue
on Apr 27, 2020 - added 2 commits that reference this issue
on Apr 28, 2020 - added a commit that references this issue
on Apr 28, 2020 - added a commit that references this issue
on Feb 16, 2021
Is your feature request related to a problem? Please describe.
I'm currently working on implementing support for native ES Modules in Jest. While both
vm.SourceTextModuleandvm.Scriptallows us to define animportModuleDynamicallyoption, this is missing fromvm.compileFunction. The option is also present inrunInContextandrunInThisContext.(I'm aware that
vm's ESM APIs are experimental - I'm just playing with the APIs to see if they fit with Jest's use cases for them. It's currently looking really good! 🙂)Describe the solution you'd like
The option should be added to
compileFunctionas well, to have parity with the othervmfunctions/constructs.Describe alternatives you've considered
Not using
compileFunctionand sticking tovm.Scriptfor CommonJS. I'd really like to avoid that as we just migrated tocompileFunctionwhich made V8 code coverage mapping from source maps way easier than the old manual module wrapper we use invm.Scripts. Also, it's a bit cleaner on our side when we can avoid manually creating the module wrapper.