Wrong hint message when parsing expression such as {a:1}['a'] === 1 in node #31820

Activity

1. targos commented on Feb 16, 2020

   

   targos

   on Feb 16, 2020

   Member

   More actions

   @BridgeAR
2. devsnek commented on Feb 16, 2020

   

   devsnek

   on Feb 16, 2020

   Member

   More actions

   The two ways this is parsed:

   • ({ a: 1 }['a'] === 1); in preview
   • { a:1; }; ['a'] === 1; in repl eval

   We should probably eagerly try to wrap all input in parens in the actual evaluator.

   👍React with 👍3Reacted by Anna Henningsen, Nikita Skovoroda and Ruben Bridgewater
3. addaleax

   added

   replIssues and PRs related to the REPL subsystem.Issues and PRs related to the REPL subsystem.

   on Feb 16, 2020
4. codebytere commented on Feb 18, 2020

   

   codebytere

   on Feb 18, 2020

   Member

   More actions

   Mind if i take a stab at this one?

   👍React with 👍3Reacted by Anna Henningsen, Michaël Zasso and Ruben Bridgewater
5. codebytere

   self-assigned this

   on Feb 22, 2020
6. tniessen commented on Feb 24, 2020

   

   tniessen

   on Feb 24, 2020

   Member

   More actions

   We should probably eagerly try to wrap all input in parens in the actual evaluator.

   That might break working code, or am I missing something?

   class Foo {} function foo() {} contains two valid declarations, but not if wrapped as an expression in parentheses.
7. devsnek commented on Feb 24, 2020

   

   devsnek

   on Feb 24, 2020

   Member

   More actions

   @tniessen if the code isn't valid with parens, parens are not used. the logic should more or less be: try { parse(wrap(input)); input = wrap(input); } catch {}
8. codebytere commented on Feb 27, 2020

   

   codebytere

   on Feb 27, 2020

   Member

   More actions

   Closed in #31943.
9. codebytere

   closed this as completedon Feb 27, 2020