Event 'close' emits twice (fs.createWriteStream)

if i set (emitClose: false) then on version 12.14.1 event emits once.
Documentation: By default, the stream will not emit a 'close' event after it has been destroyed. This is the opposite of the default for other Writable streams. Set the emitClose option to true to change this behavior.

const fileWriteStream = fs.createWriteStream(saveTo, {emitClose: true});
file.pipe(fileWriteStream);
fileWriteStream.on('close', function () {
console.log('fileWriteStream.on(close')
}

const fs = require('fs')
const fileReadStream = fs.createReadStream('1.in')
const fileWriteStream = fs.createWriteStream('1.out', {
  emitClose: true
})

fileReadStream.pipe(fileWriteStream)
fileWriteStream.on('close', function () {
  console.log('fileWriteStream.on(close)')
})

fileWriteStream.on(close)
fileWriteStream.on(close)

with node v13.6.0

more examples:

const fs = require('fs')
const fileWriteStream = fs.createWriteStream('1.out', {
  emitClose: true
})
fileWriteStream.on('close', () => {
  console.log('called')
})

fileWriteStream.write('1')
fileWriteStream.write('2')

fileWriteStream.end()

const fs = require('fs')
const fileWriteStream = fs.createWriteStream('1.out', {
  emitClose: true
})
fileWriteStream.on('close', () => {
  console.log('called')
})

fileWriteStream.write('1')
fileWriteStream.write('2')

fileWriteStream.destroy()

events.js:298
      throw er; // Unhandled 'error' event
      ^

Error [ERR_STREAM_DESTROYED]: Cannot call write after a stream was destroyed
?[90m    at WriteStream._write (internal/fs/streams.js:415:33)?[39m
?[90m    at WriteStream.<anonymous> (internal/fs/streams.js:411:12)?[39m
?[90m    at Object.onceWrapper (events.js:428:26)?[39m
?[90m    at WriteStream.emit (events.js:333:22)?[39m
?[90m    at internal/fs/streams.js:402:12?[39m
?[90m    at FSReqCallback.oncomplete (fs.js:154:23)?[39m
Emitted 'error' event on WriteStream instance at:
?[90m    at errorOrDestroy (internal/streams/destroy.js:128:12)?[39m
?[90m    at onwriteError (_stream_writable.js:462:3)?[39m
?[90m    at onwrite (_stream_writable.js:483:7)?[39m
?[90m    at WriteStream._write (internal/fs/streams.js:415:30)?[39m
?[90m    at WriteStream.<anonymous> (internal/fs/streams.js:411:12)?[39m
    [... lines matching original stack trace ...]
?[90m    at FSReqCallback.oncomplete (fs.js:154:23)?[39m {
  code: ?[32m'ERR_STREAM_DESTROYED'?[39m
}

I think these problems have fixed on 67ed526.

And that commit hasn't published to the node.js version

related PR: #30851

I think these problems have fixed on [67ed526]

Should i close issue or developers do it?

const fileWriteStream = fs.createWriteStream('1.out', {
  emitClose: true
})

Don't use emitClose: true here. It will emit 'close' anyway. This is an internal option that is only intended for stream implementations.

Preferrably it shouldn't even be forwarded.

fs: don't emit 'close' twice if emitClose enabled

Don't use emitClose: true here. It will emit 'close' anyway. This is an internal option that is only intended for stream implementations.
Preferrably it shouldn't even be forwarded.

I tried without emitClose: true on node versions 10.16.3 and 12.14.1. You are rigth. Thank you!

fs: do not emit 'close' twice if emitClose enabled

Navigation Menu

Repository navigation

Event 'close' emits twice (fs.createWriteStream) #31366

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Event 'close' emits twice (fs.createWriteStream) #31366

Description

Activity

himself65 commented on Jan 15, 2020

himself65 commented on Jan 15, 2020

himself65 commented on Jan 15, 2020

himself65 commented on Jan 15, 2020

ledeneveugene commented on Jan 16, 2020

ronag commented on Jan 16, 2020

ledeneveugene commented on Jan 17, 2020

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions