镜像站点 · 本页由第三方 GitHub 只读镜像提供，非 GitHub 官方站点，不接受任何登录或凭据输入。前往 github.com
Skip to content

error message regression in node 13 vs 12 #31284

Closed
Closed
error message regression in node 13 vs 12#31284
Labels
v8 engineIssues and PRs related to the V8 dependency.

Description

@ljharb
ljharb
opened on Jan 9, 2020

With this file, tmp, with +x permissions:

#!/usr/bin/env node

'syntax error

node tmp in node 12 / nvm run 12 tmp begets:

$PWD/tmp:3
'syntax error
^^^^^^^^^^^^^

SyntaxError: Invalid or unexpected token
    at Module._compile (internal/modules/cjs/loader.js:895:18)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:995:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Function.Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module.runMain (internal/modules/cjs/loader.js:1047:10)
    at internal/main/run_main_module.js:17:11

node tmp in node 13.6 / nvm run 13 tmp begets:

$PWD/tmp:1
#!/usr/bin/env node
^

SyntaxError: Invalid or unexpected token
    at wrapSafe (internal/modules/cjs/loader.js:1060:16)
    at Module._compile (internal/modules/cjs/loader.js:1108:27)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1164:10)
    at Module.load (internal/modules/cjs/loader.js:993:32)
    at Function.Module._load (internal/modules/cjs/loader.js:892:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)
    at internal/main/run_main_module.js:17:47

The error message in node 13 was highly confusing and I had no idea where the syntax error was in the actual file (which was obviously much larger) until I thought to test it in node 12.

Activity

  1. ljharb commented on Jan 9, 2020

    @ljharb
    ljharb
    on Jan 9, 2020
    SponsorMemberAuthor

    cc @nodejs/modules-active-members in case it has to do with loader changes, and in case this can be fixed before it's backported to node 12.

  2. hybrist commented on Jan 9, 2020

    @hybrist
    hybrist
    on Jan 9, 2020
    Contributor

    Does this happen without the shebang as well or is this specific to it?

    Previously reported issue: nodejs/modules#464

  3. devsnek
    added
    v8 engineIssues and PRs related to the V8 dependency.
    on Jan 9, 2020

  4. devsnek commented on Jan 9, 2020

    @devsnek
    devsnek
    on Jan 9, 2020
    Member

    This bug can reproduced in pure V8. I'd suggest reporting it upstream.

  5. GeoffreyBooth commented on Jan 9, 2020

    @GeoffreyBooth
    GeoffreyBooth
    on Jan 9, 2020
    Member

    This bug can reproduced in pure V8. I'd suggest reporting it upstream.

    Out of curiosity, how do you test that?

  6. ljharb commented on Jan 9, 2020

    @ljharb
    ljharb
    on Jan 9, 2020
    SponsorMemberAuthor

    I'll file it upstream (testing details would help), but upgrading v8 in node 12 seems like a problem since it will break the usefulness of error messages in an LTS node, so upstream or not, it seems like something we'd have to address :-/

  7. hybrist commented on Jan 9, 2020

    @hybrist
    hybrist
    on Jan 9, 2020
    Contributor
    > vm.createScript('#!/usr/bin/env node\n\n\'syntax error').runInThisContext()
evalmachine.<anonymous>:1
#!/usr/bin/env node
^

Uncaught SyntaxError: Invalid or unexpected token
> vm.createScript('#!/usr/bin/env node\n\n42-').runInThisContext()
evalmachine.<anonymous>:3
42-


Uncaught SyntaxError: Unexpected end of input

    Looks like it's specific to certain kinds of SyntaxError only?

  8. devsnek commented on Jan 9, 2020

    @devsnek
    devsnek
    on Jan 9, 2020
    Member

    @jkrems The issues are actually unrelated. Note where the arrow is pointing @SMotaal's issue.

    @GeoffreyBooth I have a local checkout and build of V8, which includes a command-line debugging tool called d8. https://v8.dev/docs/d8

  9. ljharb commented on Jan 9, 2020

    @ljharb
    ljharb
    on Jan 9, 2020
    SponsorMemberAuthor

    Filed https://bugs.chromium.org/p/v8/issues/detail?id=10110, it'd be great if folks helped flesh it out.

  10. ljharb commented on Jan 9, 2020

    @ljharb
    ljharb
    on Jan 9, 2020
    SponsorMemberAuthor

    @devsnek given that the node 13 error comes from at wrapSafe (internal/modules/cjs/loader.js:1060:16), doesn't that imply it's an issue in node's CJS loader and not in v8?

  11. hybrist commented on Jan 9, 2020

    @hybrist
    hybrist
    on Jan 9, 2020
    Contributor

    @ljharb Since the same (bad) behavior can be seen without wrapSafe, I think there's definitely still a V8 bug. Once the V8 behavior is fixed, we could see if there's a secondary bug in node as well.

  12. ljharb commented on Feb 4, 2020

    @ljharb
    ljharb
    on Feb 4, 2020
    SponsorMemberAuthor

    The v8 behavior seems to be fixed (according to the v8 issue)! I'm not sure which version of v8 it will land in, nor which version of node. It'd be great if someone in @nodejs/v8 could update this issue :-)

  13. hybrist commented on Feb 4, 2020

    @hybrist
    hybrist
    on Feb 4, 2020
    Contributor

    It landed after the branch cut for 8.1 which means so far it only landed in 8.2 releases. Not sure how likely it is to be backported to 7.8 or 7.9 unless we actively pursue it.

  14. mmarchini commented on Mar 10, 2020

    @mmarchini
    mmarchini
    on Mar 10, 2020
    Contributor

    Requested backport to 8.1 on the upstream bug. I think it's unlikely they'll backport to 7.9 (and even more unliekly to 7.8), so we should look into floating patches to fix it on v12 and v13.

  15. mmarchini
    added a commit that references this issue on Mar 10, 2020

    deps: V8: cherry-pick f9257802c1c0

    abd0c59
  16. addaleax
    closed this as completedin 75da64con Mar 13, 2020
  17. BridgeAR
    added a commit that references this issue on Mar 17, 2020

    deps: V8: cherry-pick f9257802c1c0

    612ee7d

  18. mmarchini commented on Mar 19, 2020

    @mmarchini
    mmarchini
    on Mar 19, 2020
    Contributor

    Just a heads up: with the upgrade of V8 on master, this bug resurfaced. I'm trying to get it back ported upstream so we don't have to float another patch. If we get close to the release date for v14.x and it's not backported upstream yet, I'll float the patch again. I'll reopen it just to keep track, but it shouldn't affect any of the existing release lines.

  19. mmarchini
    reopened this on Mar 19, 2020
  20. MylesBorins
    added a commit that references this issue on Mar 24, 2020

    deps: V8: cherry-pick f9257802c1c0

    ae90bcc
  21. targos
    added a commit that references this issue on Apr 22, 2020

    deps: V8: cherry-pick f9257802c1c0

    2e92cb4

  22. targos commented on Nov 20, 2021

    @targos
    targos
    on Nov 20, 2021
    Member

    I assume this is resolved now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    v8 engineIssues and PRs related to the V8 dependency.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions