Repository navigation
--experimental modules flags should have warnings #30600
Copy link
Copy link
Closed
Labels
esmIssues and PRs related to the ECMAScript Modules implementation.Issues and PRs related to the ECMAScript Modules implementation.good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.help wantedIssues that need assistance from volunteers or PRs that need help to proceed.Issues that need assistance from volunteers or PRs that need help to proceed.
Description
Activity
- addedesmIssues and PRs related to the ECMAScript Modules implementation.Issues and PRs related to the ECMAScript Modules implementation.
on Nov 22, 2019 If multiple experimental flags specified, should these warnings emitted separately for every flag, or merged into one?
Reacted by Myles BorinsI would prefer one for each. Warning consolidation is a separate consideration for Node.js more generally I think.
For at least
--experimental-json-modules,--experimental-wasm-modulesit should be possible to move the warnings to their first use.For
--experimental-resolve-selfand--experimental-conditional-exportsthe first use would be within C++ code and applies both to the CJS and ESM resolver implementations so may be a bit trickier, but it is in theory possible.- addedgood first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.help wantedIssues that need assistance from volunteers or PRs that need help to proceed.Issues that need assistance from volunteers or PRs that need help to proceed.
on Nov 25, 2019 - added a commit that references this issue
on Dec 9, 2019 - added a commit that references this issue
on Jan 12, 2020 - added a commit that references this issue
on Feb 6, 2020
Metadata
Metadata
Assignees
Labels
esmIssues and PRs related to the ECMAScript Modules implementation.Issues and PRs related to the ECMAScript Modules implementation.good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.help wantedIssues that need assistance from volunteers or PRs that need help to proceed.Issues that need assistance from volunteers or PRs that need help to proceed.
Currently the following experimental modules flags don't have warnings:
--experimental-json-modules--experimental-wasm-modules--experimental-resolve-self--experimental-conditional-exports--es-module-specifier-resolution=nodeIdeally when using any of these flags we should provide a warning message that not only is the base experimental modules implementation unstable, but these flags are not even clear if they will be provided as final features in the implementation and any of them might be removed still.