Getting the error "Assertion failed (wrap->ssl_) != (nullptr), file src\tls_wrap.cc, line 320" while module installation by npm

I get the error "Assertion failed (wrap->ssl_) != (nullptr), file src\tls_wrap.cc, line 320" trying to install any module by npm via proxy, for example, request or cheerio:

npm config set proxy http://username:password@proxy.company.com:8080
npm config set https-proxy https://username:password@proxy.company.com:8080

npm install cheerio

//

Thus, request module is not installed at all, and cheerio module is installed without dependencies.

//

npm --version
2.14.3

node --version
v4.1.0

OS: windows xp sp3

@indutny

cc @indutny

/cc @nodejs/crypto, @nodejs/platform-windows (windows xp sp3 sets off red flags for me)

@othiym23

Npm folks might also be interested. cc @othiym23 @zkat @iarna

Will look at it today...

I think it may be related to the Windows XP indeed. Checking the libuv code with this regards.

Hm... looks like I was wrong about it, the order of callbacks should be correct even on XP. Continuing the search.

@saghul

I think it may be a windows-specific thing. May I ask you to give a try to the following patch:

diff --git a/lib/_tls_wrap.js b/lib/_tls_wrap.js
index 1bff757..fc9696f 100644
--- a/lib/_tls_wrap.js
+++ b/lib/_tls_wrap.js
@@ -296,7 +296,11 @@ proxiedMethods.forEach(function(name) {

 tls_wrap.TLSWrap.prototype.close = function closeProxy(cb) {
   if (this._parentWrap && this._parentWrap._handle === this._parent) {
-    setImmediate(cb);
+    if (this._parentWrap._handle)
+      this._parentWrap.once('close', cb);
+    else
+      setImmediate(cb);
+
     return this._parentWrap.destroy();
   }
   return this._parent.close(cb);

Hopefully, it will fix the problem

@saghul a question about Windows and uv_close(). There is lots of endgames and everything for cancelling the request. Could it be the case that the uv_close_cb is not invoked on next libuv tick on Windows?

tls: use parent handle's close callback

Relevant PR: #2991

a question about Windows and uv_close(). There is lots of endgames and everything for cancelling the request. Could it be the case that the uv_close_cb is not invoked on next libuv tick on Windows?

Yes, AFAIK cancellation could take a bit, so the uv_close callback is not guaranteed to run exactly on the next tick.

@SergeKornilov

@SergeKornilov may I ask you to test this patch? I have really good expectations from it. Let me know if you need some help with building this thing.

@indutny

@indutny It something goes wrong when I try to build node.js. I follow installation guide:

Start "Visual Studio Command prompt (2010)"
Execute "set path=c:\python27;c:\python27\lib;%path%"
Execute "python --version" to check and get the result "Python 2.7.10"
Then execute "vcbuild.bat release x86" and get nothing.

What's wrong here? obsolet version of VS?

cc @nodejs/release how do we do builds for Windows?

@indutny

@indutny Am I correct that the problem could be observed only on windows platform?

@ChALkeR

@ChALkeR so far it looks like this

I have the same problem in Win XP.
I try install a express with command line npm install express -g and I get the msg ""Assertion failed (wrap->ssl_) != (nullptr), file src\tls_wrap.cc, line 320"

Where do I put this code?

I do not find the file tls_wrap.cc.

@veneMarcos

@veneMarcos tls_wrap.cc is here: https://github.com/nodejs/node/blob/master/src/tls_wrap.cc , but I'm not exactly sure why are you trying to find it. The patch is against _tls_wrap.js, which could be found here: https://github.com/nodejs/node/blob/master/lib/_tls_wrap.js .

I get the same error on win xp, when I've run npm install

npm --proxy http://191.168.1.1:3128 --without-ssl --insecure install string.
I think it because I using proxy in my local arean network.

node --version
v4.1.2

tls: use parent handle's close callback

Please give it a try to node.js 4.2.0 . The problem should be fixed there.

Thank you very much! 4.2.0 really works great!

Thank you, this version 4.2.0 works fine.

Whoa, looks like it was a good call to include that fix into release. Thank you!

I'm seeing this issue in node 4.4 running on win 7 and ubuntu 14.04.4 LTS. The error is printed when an ssl socket is closed. I'm only using the built in modules http, https, crypto. My code runs fine without the https module. Sorry if I've posted in the wrong place but this is the only reference I can find to this error. The error message is "Assertion failed: (wrap->ssl_) != (nullptr), file src\tls_wrap.cc, line 319".

@mypuem

@mypuem If you still get that with the latest v4.x release (v4.4.2 at the time of writing), can you file a new issue and include steps to reproduce? The test case should preferably not depend on any third-party modules.

tls: use parent handle's close callback

Navigation Menu

Repository navigation

Getting the error "Assertion failed (wrap->ssl_) != (nullptr), file src\tls_wrap.cc, line 320" while module installation by npm #2979

24 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Getting the error "Assertion failed (wrap->ssl_) != (nullptr), file src\tls_wrap.cc, line 320" while module installation by npm #2979

Description

Activity

ChALkeR commented on Sep 21, 2015

rvagg commented on Sep 21, 2015

thefourtheye commented on Sep 21, 2015

indutny commented on Sep 21, 2015

indutny commented on Sep 21, 2015

indutny commented on Sep 21, 2015

indutny commented on Sep 21, 2015

indutny commented on Sep 21, 2015

saghul commented on Sep 22, 2015

indutny commented on Sep 24, 2015

SergeKornilov commented on Sep 25, 2015

indutny commented on Sep 25, 2015

24 remaining items

ChALkeR commented on Oct 7, 2015

indutny commented on Oct 7, 2015

veneMarcos commented on Oct 7, 2015

veneMarcos commented on Oct 8, 2015

ChALkeR commented on Oct 8, 2015

wwwork commented on Oct 12, 2015

indutny commented on Oct 12, 2015

SergeKornilov commented on Oct 13, 2015

veneMarcos commented on Oct 13, 2015

indutny commented on Oct 13, 2015

mypuem commented on Apr 11, 2016

bnoordhuis commented on Apr 11, 2016

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions