Repository navigation
test-torque.tq failing source tarball builds for v12.11.0 (V8 7.7) #29709
Description
Activity
- changed the title
[-]x86 builds broken since v12.11.0 (V8 7.8)[/-][+]x86 builds broken since v12.11.0 (V8 7.7)[/+]on Sep 26, 2019 Actually yeah, I removed x86 from the unofficial-builds pipeline and the musl build broke with the same error: https://unofficial-builds.nodejs.org/logs/201909260213-v12.11.0/musl.log
So the title is wrong for this issue, it's not x86 specific.
Can reproduce by unpacking tarball, running configure, and then make (on Debian and Alpine):
docker run --rm gcc bash -c 'curl https://nodejs.org/dist/v12.11.0/node-v12.11.0.tar.xz | tar -xJ && cd node-v12.11.0 && ./configure && make -j4'- changed the title
[-]x86 builds broken since v12.11.0 (V8 7.7)[/-][+]test-torque.tq failing source tarball builds for v12.11.0 (V8 7.7)[/+]on Sep 26, 2019 I can reproduce on a
muslbased system:INFO: Using floating patch "tools/icu/patches/64/source/common/putil.cpp" from "tools/icu" INFO: Using floating patch "tools/icu/patches/64/source/i18n/dtptngen.cpp" from "tools/icu" INFO: configure completed successfully make -C out BUILDTYPE=Release V=0 touch /home/goldie/.cache/kiss/build-17145/nodejs/out/Release/obj.target/tools/v8_gypfiles/v8_version.stamp make[1]: *** No rule to make target '../deps/v8/test/torque/test-torque.tq', needed by '0c23b8358f0f4da23b589e1b64ee728c8b90e303.intermediate'. Stop. make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:101: node] Error 2Very simple build options to reproduce:
./configure \ --prefix=/usr makePart of the V8 7.7 update (#28918) added this:
Line 85 in 4d2856e
Our source tarballs currently exclude everything in
deps/v8/test:
Line 1040 in d36b6f8
#29712 includes
deps/v8/test/torquein the source tarball but still excludes the rest ofdeps/v8/testand should fix the build from the source tarball.The V8 7.7 update didn't really add that line. It just made it explicit (the list was generated by a script before).
For those wanting a quick fix for the current tarball:
- Grab
deps/v8/test/torque/test-torque.tqfrom the repository. - Add it to the extracted tarball source in the same location.
~~While my build hasn't yet completed, it has been running for 20~ minutes now. It'd be great to know if more is needed to fix this present issue.~~ Build succeeded with above workaround.
Reacted by Marcin Konicki- Grab
I suggest we fix that issue soon and release a patch release right after.
- added 2 commits that reference this issue
on Sep 26, 2019 Confirmed that @dylanaraps' method of including
deps/v8/test/torque/test-torque.tqalone is enough to get it to build. Here's a one-liner with curl to get it into your build:curl -sfSL https://github.com/nodejs/node/archive/${VERSION}.tar.gz | tar -xz --strip-components=1 -- node-12.11.0/deps/v8/test/torque/test-torque.tqI used it successfully to build on Alpine: https://github.com/mhart/alpine-node/blob/12.11.0/Dockerfile#L35
Reacted by Tony Habash and Rui Chen- added a commit that references this issue
on Oct 1, 2019 - added a commit that references this issue
on Jul 27, 2026
EDIT: this is not x86 specific, see further comments below.
Holding up the unofficial-builds of v12.11.0 (we don't handle failures yet, so they're all blocked for now). Here's the failing build log for x86: https://unofficial-builds.nodejs.org/logs/201909252318-v12.11.0/x86.log
Key part:
We don't officially support them but have plenty of users, so if we can address this it would be really great. It's V8-related and I don't know how to go about assessing whether this is easy to address.
@nodejs/v8 any help getting this addressed on master would be greatly appreciated.