镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

NAPI version check fail in test/parallel/test-process-versions.js #29509

Description

@devsnek

i'm seeing this test fail locally:

assert.strictEqual(process.config.variables.napi_build_version,
process.versions.napi);

> process.config.variables.napi_build_version
'4'
> process.versions.napi
'5'
> 

cc @nodejs/n-api

Activity

  1. added
    testIssues and PRs related to Node.js core tests and test infrastructure.
    node-apiIssues and PRs related to Node-API.
    on Sep 9, 2019
  2. addaleax commented on Sep 9, 2019

    @addaleax
    Member

    Does re-running ./configure help?

  3. devsnek commented on Sep 9, 2019

    @devsnek
    MemberAuthor

    @addaleax that did fix it. is that a bug in our automatic running of ./configure?

  4. addaleax commented on Sep 9, 2019

    @addaleax
    Member

    @devsnek I think this would require re-running ./config.status when src/node_version.h changes… that migth be doable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    node-apiIssues and PRs related to Node-API.testIssues and PRs related to Node.js core tests and test infrastructure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions