镜像站点 · 本页由第三方 GitHub 只读镜像提供，非 GitHub 官方站点，不接受任何登录或凭据输入。前往 github.com

Repository navigation

stream: event contract #29005

Closed

Labels

opened

Try to follow the assumed "contract"/"api" in terms of stream events:

events (only close after error, nothing after close, only error or close after destroy)

don't emit finish on error (stream: don't emit finish on error #28979)
document when destroy emits events (doc: clarify when destroy emits events #28970)
don't emit open after destroy ([x] fs: don't emit open after destroy #28765)
don't emit after 'error' (stream: don't emit after 'error' #28708)
don't emit finish on error (stream: don't emit finish on error #28979)
eos premature close (stream: eos premature close #28720)

addaleax
added
streamIssues and PRs related to Node.js streams.
on Aug 6, 2019
Fishrock123
added
metaIssues and PRs related to the general management of the project.
on Aug 7, 2019
Fishrock123 commented on Aug 7, 2019
Fishrock123
on Aug 7, 2019
Contributor
Are these supposed to be check off?
ronag commented on Aug 8, 2019
ronag
on Aug 8, 2019
MemberAuthor
I checked them when there was a PR. But maybe it makes more sense to check them when it's been merged.
ronag commented on Oct 6, 2019
ronag
on Oct 6, 2019
MemberAuthor
I'm moving this into my own list and will open PR's accordingly when my number of open PR's drop.
ronag
closed this as completed on Oct 6, 2019

to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests