eos and pipeline will deadlock if streams are not in assumed state #28650

Activity

1. ronag

   changed the title [-]eos and pipeline will deadlock if source is already closed [/-] [+]eos and pipeline will deadlock if streams are not in valid state[/+] on Jul 12, 2019
2. ronag

   changed the title [-]eos and pipeline will deadlock if streams are not in valid state[/-] [+]eos and pipeline will deadlock if streams are not in assumed state[/+] on Jul 12, 2019
3. ronag commented on Jul 12, 2019

   

   ronag

   on Jul 12, 2019

   MemberAuthor

   More actions

   I would suggest that eos be updated to work similarly to on-finished where the callback is invoked if the stream is already in a "complete" state.
4. Fishrock123

   added

   streamIssues and PRs related to Node.js streams.Issues and PRs related to Node.js streams.

   on Jul 12, 2019
5. ronag commented on Oct 6, 2019

   

   ronag

   on Oct 6, 2019

   MemberAuthor

   More actions

   This was fixed in a PR
6. ronag

   closed this as completedon Oct 6, 2019
7. jstewmon commented on Apr 14, 2020

   

   jstewmon

   on Apr 14, 2020

   More actions

   👋 Hi, @ronag do you happen to remember the PR that was supposed to fix this issue? I think I'm encountering the same issue, for which I've created a minimal reproduction.

   const { finished, PassThrough, pipeline } = require('stream');
   const http = require('http');
   
   const server = http.createServer((req, res) => {
     console.log('server: request received');
     const body = new PassThrough().end('foo');
     setTimeout(() => {
       console.log('server: pipeline begin');
       return pipeline(body, res, (err) => {
         console.log('server: pipeline end');
         if (err) {
           console.error('server: pipeline err:', err);
         }
       });
     }, 100);
   });
   
   server.listen({ host: '127.0.0.1', port: 0 }, (err) => {
     const addr = server.address();
     const uri = `http://${addr.address}:${addr.port}`;
   
     const req = http.request(uri).end();
     req.on('response', async (res) => {
       console.log('response received');
       for await (const chunk of res) {
         console.log('client: body: ', chunk.toString());
       }
       console.log('closing server');
       server.close(() => {
         console.log('server closed');
       });
     });
   
     finished(req, (err) => {
       console.log('client: end');
       if (err) {
         console.error('client: error: ', err);
       }
     });
   
     // aborted request will cause server pipeline to never complete
     setTimeout(() => req.abort(), 50);
   });

   Without the req.abort() call, the process with exit with output:

   client: end
   server: request received
   server: pipeline begin
   server: pipeline end
   response received
   client: body:  foo
   closing server
   server closed
   

   With the req.abort() call, the process will not exit with output:

   client: end
   server: request received
   server: pipeline begin
   

   I get the same behavior on node versions 10, 12 and 13.

   Is this the expected behavior? If so, can you point me in the right direction on how this should be handled on the server side?

   cc @mcollina
8. ronag commented on Apr 14, 2020

   

   ronag

   on Apr 14, 2020

   MemberAuthor

   More actions

   #31509

   It will be included in Node 14

   👍React with 👍1Reacted by Jonathan Stewmon