镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Certificate issues on the custom-suites-freestyle CI #28610

Description

@BridgeAR

A couple of tests consistently fail on our custom-suites-freestyle CI.

  • test.parallel/test-https-client-reject
  • test.parallel/test-https-pfx
  • test.parallel/test-tls-client-reject
  • test.parallel/test-tls-client-reject-12
  • test.parallel/test-tls-connect-no-host

See e.g., https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/7863/#showFailuresLink

I can't look into it right now, so @nodejs/build @nodejs/crypto PTAL

Activity

  1. added
    testIssues and PRs related to Node.js core tests and test infrastructure.
    flaky-testIssues and PRs involving tests that fail intermittently in CI.
    on Jul 9, 2019
  2. bnoordhuis commented on Jul 9, 2019

    @bnoordhuis
    Member

    Maybe not relevant but this shows up in the build log:

    18:16:46 python ./configure --verbose 
    18:16:47 WARNING: C++ compiler too old, need g++ 6.3.0 or clang++ 8.0.0 (CXX=ccache g++)
    

    Is there anything else that's unusual about this machine?

  3. cjihrig commented on Jul 9, 2019

    @cjihrig
    Contributor

    I thought @sam-github fixed this recently too?

  4. sam-github commented on Jul 10, 2019

    @sam-github
    Contributor

    I don't think so, I did some ubuntu14.04 maintenance on IBM platforms, but I don't think I did anything for 1604 on x86, and I just scanned my PRs into nodejs/build, nothing seems relevant.

  5. richardlau commented on Jul 10, 2019

    @richardlau
    Member

    @sam-github I think @cjihrig was referring to the PR that fixed up the test fixture certificates validity dates (#28473). Perhaps the failures are for PR's that need to be rebased to pick up the fixed fixtures (although if that was the case we'd probably expect the failures to show up in other jobs too (unless there's something different about the way this job rebases))?

  6. added
    tlsIssues and PRs related to the tls subsystem.
    on Jul 11, 2019
  7. addaleax commented on Jul 14, 2019

    @addaleax
    Member

    I think this is a build infra issue, otherwise this wouldn’t be failing on just one machine, right?

  8. richardlau commented on Jul 15, 2019

    @richardlau
    Member

    (unless there's something different about the way this job rebases))?

    It's most probably related to nodejs/build#1790.

  9. richardlau commented on Jul 18, 2019

    @richardlau
    Member

    This has been fixed (nodejs/build#1790 (comment)). The job in question was not calling the script that rebases the PR on top of the current master branch correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    flaky-testIssues and PRs involving tests that fail intermittently in CI.testIssues and PRs related to Node.js core tests and test infrastructure.tlsIssues and PRs related to the tls subsystem.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions