test: test.py leaks pseudo-tty master fd to child

Lest I forget: the master fd created here:

Line 723 in 20d099a

(out_master, fd_out) = pty.openpty()

Is leaked to the spawned child here:

Lines 761 to 772 in 20d099a

    
           (process, exit_code, timed_out, output) = RunProcess( 
        
             context, 
        
             timeout, 
        
             args = args, 
        
             stdin = fd_in, 
        
             stdout = fd_out, 
        
             stderr = fd_err, 
        
             env = env_copy, 
        
             faketty = faketty, 
        
             pty_out = pty_out, 
        
             preexec_fn = preexec_fn 
        
           )

Fix: the preexec_fn should os.close(pty_out).

#28600 should fix the pty hangs on AIX. It came a long way...

test: fix pty test hangs on aix

Please ignore this msg (#1)

test: fix pty test hangs on aix

Navigation Menu

Repository navigation

test: test.py leaks pseudo-tty master fd to child #28489

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	(process, exit_code, timed_out, output) = RunProcess(
	context,
	timeout,
	args = args,
	stdin = fd_in,
	stdout = fd_out,
	stderr = fd_err,
	env = env_copy,
	faketty = faketty,
	pty_out = pty_out,
	preexec_fn = preexec_fn
	)

test: test.py leaks pseudo-tty master fd to child #28489

Description

Activity

bnoordhuis commented on Jul 8, 2019

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions