Repository navigation
N-API: Expose v8::Object::GetIdentityHash #28195
Description
Activity
n-api is a JS engine abstraction layer and I don't think every JS engine has an equivalent feature. For example, I don't think Spidermonkey has anything like it.
It is a pre-req that an N-API call be able to be implemented on top of any of the the leading JS engines (with the goal of it being ALL)
That would be a problem, yes. Spidermonkey has
mozilla::HashGenericand friends, which is used by its implementation of the JSMapclass, but this does not seem to be part of the public API.@argv-minus-one does #28237 obviate the need for this?
I'm going to close this out as "not implementable."
Is your feature request related to a problem? Please describe.
A solution suggested for #28164 was to keep a big table of JS objects and their types, and use that to verify the type of a wrapper object before
napi_unwrapping it. Currently, the only way to do this is tonapi_strict_equalsagainst every single object reference in the table, which is very slow if there are a lot of objects to keep track of.Describe the solution you'd like
Please expose
v8::Object::GetIdentityHashthrough N-API. This will make it possible to maintain a hash table of JS object references.Describe alternatives you've considered
See #28164.