Repository navigation
Defining OPENSSL_THREADS in common.gypi broke my Electron native addon build #27540
Description
Activity
Hello @murgatroid99 and thank you for the report. You can un-define this macro in your
binding.gyp, using GYP's exclude-from-list!suffix:'defines!': [ 'OPENSSL_THREADS' ],P.S. Or follow the suggestions in electron/electron#18122 (comment)
I'll close this out as a workaround exists and I don't think it's a change we'll roll back. Without exporting
OPENSSL_THREADSyou can't use some APIs from openssl/crypto.h safely or at all.
Change #23426 added a section to
common.gypithat conditionally definesOPENSSL_THREADS. This change was integrated into Electron 5 and as a result my native addon that depends on BoringSSL under Electron now fails to build under Electron 5 with the following error message:The full bug details are at electron/electron#18122.