Repository navigation
createRequireFromPath does not support directories with a trailing slash #27527
Description
Activity
@mscdex since
createRequireuses it under the hood the behavior is inherited.This actually seems like the expected behaviour to me?
Shouldn't
createRequireFromPath()raise an error if the path is not (or does not quack like) a directory?@Fishrock123 since it is a wrapper around
new Moduleit actually expects a file to be passed, not a directory.import.meta.urlfor example is a file path, not directory. So if there was an error for non paths thenimport.meta.urlwould errorafaik this was properly fixed by ef51cc8
Metadata
Metadata
Assignees
Labels
No labels
Follow up from e5c8be2
TL;DR
createRequireFromPath('/path/to/dir')has unexpected behavior as it is treated as a file not a directory...createRequireFromPath('/path/to/dir/')works as expected.Seems like the only way forward would be to introduce a synchronous file / directory stat... which imho is undesirable but I totally see why this creates unexpected behavior.
/cc @BridgeAR @addaleax @devsnek