镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

backport ICU-20575 to fix err/crasher in ICU 64.x #27418

Description

@srl295
  • Subsystem: deps

Tracking: unicode-org/icu#634
Now that #27361 (ICU 64.2) landed, it would be good to pull this in.

This probably exacerbated #27379 on some platforms.

Activity

  1. added
    i18n-apiIssues and PRs related to Node.js internationalization support.
    on Apr 25, 2019
  2. srl295 commented on Apr 25, 2019

    @srl295
    MemberAuthor
  3. self-assigned this
    on Apr 25, 2019
  4. srl295 commented on Apr 25, 2019

    @srl295
    MemberAuthor

    Test case:

    env LANG=fr@EURO ./out/Debug/node -p 'new Intl.NumberFormat().resolvedOptions().locale

    Crashes with:

    Fatal error in ../../deps/v8/src/objects/intl-objects.cc, line 417

    Locale::forLocaleTag("fr-x-lvariant-euro-euro") returns U_ILLEGAL_ARGUMENT_ERROR (why? Perhaps an illegal doubled tag.)

    After the fix the printout is fr-x-lvariant-euro

    (for unknown reasons, v8 patched around some of the other behaviors, so the output will look different than the upstream issue.)

  5. targos commented on Apr 27, 2019

    @targos
    Member

    Fixed in #27435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

i18n-apiIssues and PRs related to Node.js internationalization support.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions