You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
AssertionError crash at ServerResponse.resOnFinish #2639
This seems to be related to #1411. @indutny Any idea what's happening here?
Stacktrace:
AssertionError: false == true
at ServerResponse.detachSocket (_http_server.js:144:3)
at ServerResponse.resOnFinish (_http_server.js:483:11)
at emitNone (events.js:67:13)
at ServerResponse.emit (events.js:166:7)
at finish (_http_outgoing.js:526:10)
at doNTCallback0 (node.js:407:9)
at process._tickDomainCallback (node.js:377:13)
I'm running into the same issue with node 4.1.0 using just Express. Looks like socket.io folks are seeing this too: socketio/socket.io#2236 😭 Definitely not RAM: 16 GB here.
I may have fixed it with an npm update to pull in updated dependencies (instead of just using whatever version was saved when I did npm install X --save who-knows-when).
yeah of course, we can, as I wrote this is only fix, I didn't want to make bigger changes that I think should be done here... I don't know anything about your guidelines and so on, I was just unhappy of node falling down every few minutes and it was a good reason to look a bit under the cover...:)
@indutny@mareksrom sorry I'm a little unclear on the status of your patches—should we be testing them, or are they both in flux? Apologies for being dense…
I ask because @arthurschreiber seems to have experienced assertion failure with @indutny's patch.
I believe @mareksrom's patch is in the closest state to being merged; either way we'll have a release out this week with a fix in it as it seems like the cause has been fully diagnosed now.
Activity
mscdex commentedon Sep 2, 2015
Did you try with other versions, like io.js 2.5.0?
arthurschreiber commentedon Sep 15, 2015
We see the same error with Node 4.0 on our RHEL 6 machines. We haven't seen this issue with io.js 2.5.0.
arthurschreiber commentedon Sep 15, 2015
This seems to be related to #1411. @indutny Any idea what's happening here?
Stacktrace:
fasiha commentedon Sep 20, 2015
I'm running into the same issue with node 4.1.0 using just Express. Looks like socket.io folks are seeing this too: socketio/socket.io#2236 😭 Definitely not RAM: 16 GB here.
fasiha commentedon Sep 20, 2015
I may have fixed it with an
npm updateto pull in updated dependencies (instead of just using whatever version was saved when I didnpm install X --savewho-knows-when).khoikng commentedon Sep 20, 2015
I'm running into the same issue with iojs 3.0.0 :( Any update on this?
@fasiha how are you going with npm update?
61 remaining items
mareksrom commentedon Sep 25, 2015
yeah of course, we can, as I wrote this is only fix, I didn't want to make bigger changes that I think should be done here... I don't know anything about your guidelines and so on, I was just unhappy of node falling down every few minutes and it was a good reason to look a bit under the cover...:)
fasiha commentedon Sep 29, 2015
@indutny @mareksrom sorry I'm a little unclear on the status of your patches—should we be testing them, or are they both in flux? Apologies for being dense…
I ask because @arthurschreiber seems to have experienced assertion failure with @indutny's patch.
rvagg commentedon Sep 29, 2015
I believe @mareksrom's patch is in the closest state to being merged; either way we'll have a release out this week with a fix in it as it seems like the cause has been fully diagnosed now.
fasiha commentedon Sep 29, 2015
🎉 so happy! Thanks everyone 🍻
rvagg commentedon Oct 5, 2015
Please upgrade to v4.1.2 and confirm that this problem has been resolved.
ahwayakchih commentedon Oct 6, 2015
Hi, i started noticing problem, searched for info, found this issue, updated to 4.1.2 and now the problem is gone. Thanks!
gesposito commentedon Oct 8, 2015
It used to crash often while developing on Windows (http-server with a lot of static requests), looks stable now, thanks.
micky2be commentedon Oct 14, 2015
Thanks
http: fix out-of-order 'finish' bug in pipelining
hi54yt commentedon Feb 3, 2016
thx!
http: fix out-of-order 'finish' bug in pipelining
http: fix out-of-order 'finish' bug in pipelining