Repository navigation
Cannot set property 'parsingHeadersStart' of undefined on 10.15.2 #26366
Description
Activity
I’ll send a PR in tomorrow morning.
Can you please include a repro if you can?
I've investigated this issue, and I cannot understand when this can happen: we are only setting the
parsertonull. Protecting this is easy to do:this check needs to be extended toLine 758 in fedc31b
undefined. However I don't understand in what conditions it can beundefinedand write a specific unit test.@rvagg @sam-github @jasnell @addaleax @apapirovski @mscdex do you have any idea?
Without a repro, no I have no idea
No idea, either 😕
I've tried to repro this locally and cannot. 😕
This happens on both of our Heroku environments however (prod and test).
The steps to repro it there for us was simply to deploy then send a request. It did not matter which request. We got this error every time. By simply reverting to 10.15.1 we were able to get our production server back up and running.
We deployed the code the was running successfully the previous day and it still failed. The only factor was the new release.Is there anything else that I might be able to provide as insight?
Are you using any framework? Which ones?
Can you run Node with
NODE_DEBUG=httpand include a few ~100 lines before the error? It might give us a clue.same issue in docker containers
@mcollina run with
NODE_DEBUG=httpHTTP 62: write ret = true HTTP 62: outgoing message end. HTTP 62: resetHeadersTimeoutOnReqEnd HTTP 62: AGENT incoming response! HTTP 62: AGENT socket keep-alive HTTP 62: CLIENT socket onFree HTTP 62: agent.on(free) x.x.x.x:80: HTTP 62: removeSocket x.x.x.x: writable: true HTTP 62: write ret = true HTTP 62: outgoing message end. HTTP 62: SERVER new http connection HTTP 62: write ret = true HTTP 62: outgoing message end. HTTP 62: SERVER socketOnParserExecute 491 HTTP 62: resetHeadersTimeoutOnReqEnd 2019-03-02 17:30:07,824 ERROR 62 nodejs.TypeError: Cannot set property 'parsingHeadersStart' of undefined (uncaughtException throw 1 times on pid:62) at IncomingMessage.resetHeadersTimeoutOnReqEnd (_http_server.js:750:32) at IncomingMessage.emit (events.js:197:13) at endReadableNT (_stream_readable.js:1129:12) at processTicksAndRejections (internal/process/next_tick.js:76:17) pid: 62 hostname: VM-1-13-ubuntuCode to reproduce:
'use strict'; const http = require('http'); const server = http.createServer((req, res) => { res.writeHead(200, { 'Content-Type': 'text/plain' }); res.write('okay', () => { delete res.socket.parser }); res.end(); }); server.listen(1337, '127.0.0.1'); const req = http.request({ port: 1337, host: '127.0.0.1', method: 'GET', }); req.end();
4 remaining items
@jasine what version of socket.io? Run
npm ls socket.io. I still can't reproduce with this:const Koa = require('koa'); const socketio = require('socket.io'); const { createServer } = require('http'); const body = `<!DOCTYPE html> <html> <head> <meta charset="utf-8"> </head> <body> <script src="/socket.io/socket.io.js"></script> <script> (function () { const socket = io('http://localhost:3000');; socket.on('connect', function() { console.log('open'); }); })(); </script> </body> </html>`; const app = new Koa(); app.use(async function(ctx) { ctx.body = body; }); const server = createServer(app.callback()); const io = socketio(server); io.on('connection', function() {}); server.listen(3000, function() { console.log('Listening on [::]:3000'); });
i have the same issue too when try to connect in socket.io
version:
"socket.io": "^2.1.0"
"socket.io-client": "^2.1.1",And i find that it will work well at node@8.15.0, and crash at node@8.15.1
@mcollina Same issue.
Here is a repro with egg.js: egg-socket.io-error-demo
Node version: v8.15.1 (and v8.15.0 is well...)
Error message:
2019-03-05 14:52:21,167 ERROR 20840 nodejs.TypeError: Cannot set property 'parsingHeadersStart' of undefined (uncaughtException throw 1 times on pid:20840) at IncomingMessage.resetHeadersTimeoutOnReqEnd (_http_server.js:728:32) at emitNone (events.js:106:13) at IncomingMessage.emit (events.js:208:7) at endReadableNT (_stream_readable.js:1064:12) at _combinedTickCallback (internal/process/next_tick.js:139:11) at process._tickCallback (internal/process/next_tick.js:181:9) pid: 20840 hostname: hyj1991.local- added 2 commits that reference this issue
on Mar 5, 2019 - added a commit that references this issue
on Mar 5, 2019 - added a commit that references this issue
on Mar 6, 2019 The problem is that
request.socketis replaced by egg-socket.io with the socket.ioSocket. See https://github.com/eggjs/egg-socket.io/blob/9e7f71d835930d3a63c69635488737066f779661/lib/connectionMiddlewareInit.js#L8-L9.This is not ok and can break again in future.
Reacted by Ruben Bridgewater, Matteo Collina, Wang Yongqiang, Mindful Design, 陈基勇, 326966697 and 易容 (hyj1991)- added 2 commits that reference this issue
on Mar 12, 2019 - added a commit that references this issue
on Apr 16, 2019 - added a commit that references this issue
on Sep 19, 2019 i have a idea ， client 不要用socket-client 换成egg-socket.io 可以
- added a commit that references this issue
on Mar 17, 2020
10.15.2
Ubuntu 18.04
Out of the blue all of my build servers started to crash today. Each time a request comes in we receive the following error.
Node crashes.
This is related to version 10.15.2.
After rolling back to 10.15.1 we do not have any more issues.