镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

test: parallel/test-dns-setserver-when-querying is sensitive to network conditions #25664

Description

@joyeecheung
  • Version: master
  • Platform: macOS Mojave 10.14
  • Subsystem: test

I have been observing timeout failure of parallel/test-dns-setserver-when-querying quite frequently lately - this seems to be sensitive to network conditions somehow.

# Behind Chinese GFW
> time out/Release/node /Users/joyee/projects/node/test/parallel/test-dns-setserver-when-querying.js
out/Release/node
0.07s user 0.02s system 1% cpu 6.032 total

# After bypassing Chinese GFW
> time out/Release/node /Users/joyee/projects/node/test/parallel/test-dns-setserver-when-querying.js
out/Release/node
0.07s user 0.02s system 38% cpu 0.226 total

From a glance I couldn't tell if this test is actually sending any network requests but from my observation I think it may need to be moved to test/internet?

(Note: this test is using the Google DNS servers to test dns.setServer - the addresses are constant targets of the Chinese GFW)

Activity

  1. added
    testIssues and PRs related to Node.js core tests and test infrastructure.
    on Jan 23, 2019
  2. Trott commented on Jan 25, 2019

    @Trott
    Member

    Maybe just change goog to [ '127.0.0.1' ] (and rename it to localhost)? Test would still seem to be valid in that situation.

    PR to do exactly that: #25694

  3. Trott commented on Jan 27, 2019

    @Trott
    Member

    Fixed in 6d937c0, I believe. (Re-open if I'm wrong, of course!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    testIssues and PRs related to Node.js core tests and test infrastructure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions